This repository has been archived by the owner on May 19, 2020. It is now read-only.
Don't persist errors in different service creation forms #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el-mapache
force-pushed
the
ab-1-1-instance-errors
branch
from
9246a91 to
52b3d07
Compare
el-mapache
force-pushed
the
ab-1-1-instance-errors
branch
from
56008f0 to
61473c7
Compare
removes goofy console logs Some code cleanup + clear form properly on cancel Fix lint error Fixes broken specs Add test for service plan component
el-mapache
force-pushed
the
ab-1-1-instance-errors
branch
from
61473c7 to
d987da4
Compare
jcscottiii
approved these changes
Aug 9, 2017
el-mapache
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maps service instance creation form errors to the underlying form object in the
ServiceInstanceStore, not to theFormorCreateServiceInstancecomponents. We clear the existing form each time a new service instance is selected for creation by calling theSERVICE_INSTANCE_CREATE_FORM_CANCELaction typeHandy GIF reference:
