This repository has been archived by the owner on May 19, 2020. It is now read-only.
More contributing documentation fixes #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 7, 2017 10:48
jcscottiii
reviewed
Jul 10, 2017
CONTRIBUTING.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| We're so glad you're thinking about contributing to an 18F open source project! If you're unsure or afraid of anything, just ask or submit the issue or pull request anyways. The worst that can happen is that you'll be politely asked to change something. We appreciate any sort of contribution, and don't want a wall of rules to get in the way of that. | |||
|
|
|||
| *Disclaimer:* Everthing in this guide is not set in stone and subject to change based on changing project requirements and tools. | |||
There was a problem hiding this comment.
Everthing - > Everything
There was a problem hiding this comment.
Made updates to merge
jcscottiii
reviewed
Jul 10, 2017
CONTRIBUTING.md
Outdated
| @@ -200,7 +202,7 @@ Here are some basic rules to work with action creators successfully: | |||
| return Promise.resolve(spaces); | |||
| } | |||
| ``` | |||
| - There should not be more then on action with the same data. | |||
| - There should not be more then one action with the same data. | |||
There was a problem hiding this comment.
Made updates to merge
jcscottiii
reviewed
Jul 10, 2017
|
@jcscottiii Made the updates. Good for merge. |
jcscottiii
approved these changes
Jul 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.