This repository has been archived by the owner on May 19, 2020. It is now read-only.
Fix org and space role association #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2017 11:44
This modification makes sure that all requests to do association/dissociation of roles use the right api key for the role. This will break tests because currently the code doesn't use the right api key for role modification
The data to how to map a role to various things was spread out. This PR moves them all into one object. Also, with moving into one object, we have the apiKey field. This field is now used
jcscottiii
force-pushed
the
js-fix-role-api
branch
from
1fa6728 to
0ed527b
Compare
| @@ -164,6 +150,7 @@ export class UserStore extends BaseStore { | |||
| const orgPermissionsReq = cfApi.deleteOrgUserPermissions( | |||
| action.userGuid, | |||
| action.orgGuid, | |||
| 'users', | |||
There was a problem hiding this comment.
@jcscottiii This might be a duplicated line
There was a problem hiding this comment.
There was a problem hiding this comment.
it's meant to be duplicated but let me re-work it so it's more clear as to why it's like that.
rememberlenny
approved these changes
Jun 14, 2017
|
@jcscottiii Merged because it does what it is supposed to do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit: Fix functional test server to check for correct roles
This modification makes sure that all requests to do
association/dissociation of roles use the right api key for the role.
This will break tests because currently the code doesn't use the right
api key for role modification but will be fixed in following commits.
Other commits: fixing the api calls and tests