This repository has been archived by the owner on May 19, 2020. It is now read-only.
Add new information #1060
Merged
Add new information #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 16, 2017 22:38
Based on new team and new performance (which is still in a PR, so not official yet)
I still need to link to some actual examples in the code, but this is a start. This should be continually added to through discussion and when more examples come up.
jcscottiii
suggested changes
Apr 17, 2017
CONTRIBUTING.md
Outdated
| #### Patterns | ||
|
|
||
| <a name="ui-actions"></a> | ||
| ##### Ui actions |
CONTRIBUTING.md
Outdated
| <a name="ui-actions"></a> | ||
| ##### Ui actions | ||
|
|
||
| When a UI is supposed to do something based on something a user did, such as clicking a a dropdown to display what's within, these actions should go through the dispatcher as an action. |
There was a problem hiding this comment.
jcscottiii
approved these changes
Apr 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on new team and new performance (which is still in a PR, so not official yet)