-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releng - try a windows build #177
Conversation
somewhat of a surprise, windows builds worked ootb, https://github.com/cloud-custodian/tfparse/actions/runs/7466017271 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, yay cibuildwheel doing its thing 😎
.github/workflows/release.yml
Outdated
# - runner: ubuntu-latest | ||
# cibw_arch: aarch64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeping this commented because it's temporary and we want the visual reminder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, those are coming back, just wanted to reduce the cycle time on testing the windows specific portion of the build.
hmm.. doesn't look like windows works in practice, even though it builds, ci failing with |
the function doesn't appear to be exported is the underlying issue, the parse function is, as super hacky thing on windows we're just going to avoid calling free for now and that means accepting a memory leak :/ the common usage for c7n_left though this is non material as we're effectively exiting after a parse, but its a strong caveat for library usage on win32 |
see what happens.