Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass allow_downloads config through to parser - fixes #158 #161

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

thugdoubt
Copy link
Contributor

The terraform parsing library defaults to allowing downloads, and tfparse was only passing the allow_downloads config value when it was not falsey, resulting in downloads always being enabled. This change always passes the allow_downloads config, allowing the expected behavior.

Copy link
Contributor

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@kapilt kapilt merged commit c41a494 into cloud-custodian:main Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants