ci - deploy docs to gh-pages on push to main #7237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jorge Castro <[email protected]>
thisisshi
approved these changes
May 5, 2022
|
we also need to disable drone else they'll both try to overwrite. |
Cool sounds good to me, I just don't recall if drone was also responsible for the piece that yoinks github pages to s3 so cloudcustodian.io would be updated. If that's entirely separate, then I guess drone could be deactivated now? (Just noticed we're tracking the move away from drone in #6786) |
shineyb
pushed a commit
to shineyb/cloud-custodian
that referenced
this pull request
May 12, 2022
Co-authored-by: Jorge Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a push to main, we already build docs. This PR adds a step to publish those built docs to GitHub Pages using this GitHub action.
This came out of some discussion with @castrojo who came across the action and wondered if/where/how it would fit into our process. Looks like it can slot in nicely right after the build we already run, as long as we set the source & target folders appropriately. Tested in my fork here.