aws - rds - add consecutive daily snapshot count filter

[jasgrover]

Adding a new filter for 'consecutive-snapshots' daily snapshots to rds and rdscluster resources so that we can determine the number of consecutive daily snapshot each resource of above mentioned type has . The compliance reporting requires that all RDS ( cluster and instance ) resources should have at least 7 days worth of backups. This filter allows to calculate the number of daily consecutive snapshots.

Sample policy

     - name: rds-backup-test-daily
       resource: rds
       filters:
             - type: consecutive-snapshots
               days: 7
             - DBInstanceStatus: available
       actions:
          - type: notify
        

I had to close the previous PR (referenced below ) and recreate this PR to resolve the CLA issues with commit ids. Please see the following CR for notes /review by @ajkerrigan and @darrendao.

#7165

[ajkerrigan]

Glad to see you got the CLA issues sorted out (apologies for the hassle - we should be able to trigger CLA checks without forcing you to open a new PR!).

This looks good, thanks! Just a couple nits and a question inline. And it looks like there's an extra pair of recorded test data files for test_rds_snapshot_count_filter that got nested under the test_rdscluster_snapshot_count_filter directory (here and here).

[jasgrover]

@ajkerrigan The reason tests are failing because the filter looks for n (2) number of snapshots going back from present date and the test replay data becomes obsolete after passing of the day from commit... reckon will have to reframe the test.

[jasgrover]

@ajkerrigan .. fixed the tests

[ajkerrigan]

@ajkerrigan .. fixed the tests

I think you had the right idea validating matches in your original tests, but like you discovered they were making assumptions about the current date. A frozen date should let us keep your original test logic.

[ajkerrigan]

Thanks for your work on this @jasgrover , and @darrendao for the assist. Looks good! 👍

[jasgrover]

Thanks for your work on this @jasgrover , and @darrendao for the assist. Looks good! 👍

Many thanks for the excellent advise and assistance all the way !!