Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/mugc - only include enabled regions for region=all #6870

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

ajkerrigan
Copy link
Member

  • Use an authenticated EC2 call to list available regions, rather than
    looking at the list of regions that are valid for a boto3 session.
    The latter can include opt-in regions which are not enabled.

  • Add a debug log message when beginning a region GC. This provides
    some opt-in feedback in verbose mode, avoiding long silences
    that can come when using region=all.

Addresses #6820

* Use an authenticated EC2 call to list available regions, rather than
  looking at the list of regions that are valid for a boto3 session.
  The latter can include opt-in regions which are not enabled.

* Add a debug log message when beginning a region GC. This provides
  some opt-in feedback in verbose mode, avoiding long silences
  that can come when using region=all.
@ajkerrigan ajkerrigan requested a review from kapilt as a code owner August 27, 2021 01:53
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit d5a0cc9 into cloud-custodian:master Aug 30, 2021
@ajkerrigan ajkerrigan deleted the mugc-all-regions branch August 30, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants