Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws.ebs-snapshot - add related filter for ebs volume #6532

Merged
merged 6 commits into from
Mar 17, 2021
Merged

aws.ebs-snapshot - add related filter for ebs volume #6532

merged 6 commits into from
Mar 17, 2021

Conversation

thisisshi
Copy link
Member

@thisisshi thisisshi commented Mar 15, 2021 •
edited
Loading

Closes #6131

name: find-snapshots-with-no-volume
resource: aws.ebs-snapshot
  filters:
    - type: volume
      key: VolumeId
      value: absent

Of course, you can also filter on volume tags, other abs volume attires, etc. as you would expect for a related resource filter.

@thisisshi thisisshi requested a review from kapilt as a code owner March 15, 2021 23:32
kapilt
kapilt reviewed Mar 16, 2021
View reviewed changes
tests/test_ebs.py Outdated Show resolved Hide resolved
kapilt
kapilt approved these changes Mar 16, 2021
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minors, else lgtm

@thisisshi thisisshi merged commit edb9a09 into cloud-custodian:master Mar 17, 2021
@thisisshi thisisshi deleted the snapshot-volume-filter branch March 17, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilt kapilt kapilt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter aws.ebs-snapshot with deleted volumes
2 participants
@thisisshi @kapilt