Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix osp-17 overcloud node count #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix osp-17 overcloud node count #116

wants to merge 1 commit into from

Conversation

masco
Copy link
Collaborator

@masco masco commented Aug 17, 2022

Description

Fixes

asyedham
asyedham approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@asyedham asyedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jtaleric
jtaleric approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to make sure you call the openstack_version role first as it now depends on rhosp_major

karelyatin
karelyatin reviewed Aug 17, 2022
View reviewed changes
roles/openstack_undercloud/tasks/main.yml Outdated
- name: Get Controller Nodes number
shell: source {{ user_homedir.stdout }}/stackrc; nova list | grep controller | grep ACTIVE | wc -l
register: controller_count
when: undercloud_conf.stat.exists
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be better to move this condition too along with the rhosp_major block condition

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@masco
Copy link
Collaborator Author

masco commented Aug 17, 2022

@jtaleric yes, openstack using this config https://github.com/cloud-bulldozer/stockpile/blob/master/config/featureset001.yml and in thisconfig, the version role is called before the undercloud role.

@asyedham
Copy link
Collaborator

@masco could you please call the openstack_version role first in stockpile.yaml playbook as it is used for running stockpile CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelyatin karelyatin karelyatin left review comments

@asyedham asyedham asyedham approved these changes

@jtaleric jtaleric jtaleric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@masco @asyedham @jtaleric @karelyatin