Allow custom context managers to see task errors #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the task fails, we should get a traceback in our context managers
we use user-specified context managers to wrap `self._execute_forked` but that function always catches all exceptions. this means that our `__exit__` function always thinks the tasks raised no error, and so do not necesserily perform proper cleanup. here, we move the context-manager wrapping closer to where we invoke the function. the downside is that, if we swallow exceptions in the context manager, we won't get retry logic, which i think is an acceptable tradeoff
Fix conflicts and style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformatted & fixed conflicts from #139 (thanks @igor47).