Add pip compile #984
Merged
Add pip compile #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neob91-close
force-pushed
the
add-pip-compile
branch
3 times, most recently
from
79fa359 to
c73e857
Compare
neob91-close
force-pushed
the
add-pip-compile
branch
10 times, most recently
from
64c1991 to
6451ade
Compare
|
Now I'm thinking maybe I should just swap out the current That shouldn't block the review of this PR though. |
squeaky-pl
approved these changes
Dec 11, 2024
What's stopping you from shipping ruff changes separately first? Doing both ruff and dependency resolver change seems like an insane amount of risk to me. |
|
I'm not sure if I'd call it "insane", but I agree it's a bit too much of a risk and that if we can easily ship ruff first, it would help 👍 |
Merged
|
Ruff PR: #985 |
neob91-close
force-pushed
the
add-pip-compile
branch
from
6451ade to
4ed08f1
Compare
|
Removed the ruff-related changes, and regenerated the requirements files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to introduce
pip-compile, but had to switch toruffas well, because we had some conflicting linting packages, and after fixing that, flake8 started reporting a whole lot of different errors.We were going to introduce
ruffanyway, I just wish we didn't have to do it all in one PR.Definitely review commits separately.