Skip to content

Commit

Permalink
MINOR: Fix shadow jar publishing for the clients module (apache#15127)
Browse files Browse the repository at this point in the history
The PR fixes the publishing of kafka-clients artifact to remote maven. The kafka-clients jar was recently shadowed which would publish the artifacts to the local maven repo successfully but would throw an error when publishing to remote maven. (as part of the release process)

The issue triggers only with publishMavenJavaPublicationToMavenRepository due to signing. Generating signed asc files error out for shadowed release artifacts as the module name (clients) differs from the artifact name (kafka-clients).

The fix is basically to explicitly define artifact of shadowJar to signing and publish plugin. project.shadow.component(mavenJava) previously outputs the name as client-<version>-all.jar though the classifier and archivesBaseName are already defined correctly in :clients and shadowJar construction.
  • Loading branch information
apoorvmittal10 authored and clolov committed Apr 5, 2024
1 parent a57f12b commit 7731a54
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ subprojects {
from components.java
} else {
apply plugin: 'com.github.johnrengelman.shadow'
project.shadow.component(mavenJava)
artifact shadowJar
}

afterEvaluate {
Expand Down

0 comments on commit 7731a54

Please sign in to comment.