Ensure text property keys are symbols. #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,7 +82,7 @@ positions before and after executing BODY." | |||
| (let ((start (cl-gensym))) | |||
| `(let ((,start (point))) | |||
| (prog1 (progn ,@body) | |||
| (add-text-properties ,start (point) ,props))))) | |||
| (add-text-properties ,start (point) (cider-intern-keys ,props)))))) | |||
There was a problem hiding this comment.
Perhaps we should fix the offending call instead of being defensive here. After all - the function was invoked with incorrect arguments.
|
Please, prefix the commit message with |
Maps received via nREPL have string keys. The Emacs Lisp text property functions expect all property keys to be symbols. Thus we must first intern any non-symbol property keys prior to applying them as text properties.
|
Good point. Made requested changes and force-pushed. |
|
👍 |
bbatsov
added a commit
that referenced
this pull request
Dec 18, 2014
Ensure text property keys are symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maps received via nREPL have string keys. The Emacs Lisp text property functions expect all property keys to be symbols. Thus we must first intern any non-symbol property keys prior to applying them as text properties. Fixes #885.