Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken cider-eval-ns-form #3202

Merged
merged 3 commits into from
May 18, 2022
Merged

Fix broken cider-eval-ns-form #3202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a617cd
cider-eval-ns-form: use "P" instead of "p"
danskarda May 17, 2022
228fb3a
Use returned ns, not a magic match-string
danskarda May 17, 2022
9b47603
Add changelog
danskarda May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
* [#3195](https://github.com/clojure-emacs/cider/issues/3195): Revert the change that resulted in `(error "Cyclic keymap inheritance")` on `cider-test-run-test`.
* [#3182](https://github.com/clojure-emacs/cider/issues/3182): Don't try to invoke
JVM-specific code outside of JVM Clojure.
* [#3202](https://github.com/clojure-emacs/cider/pull/3202): Fix `cider-eval-ns-form`
* Do not always perform `undef-all`. Undef only with `C-u` prefix.
* Fix extraction of namespace name.

## 1.4.0 (2022-05-02)

Expand Down
6 changes: 3 additions & 3 deletions cider-eval.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1333,12 +1333,12 @@ buffer, else display in a popup buffer."
(defun cider-eval-ns-form (&optional undef-all)
"Evaluate the current buffer's namespace form.
When UNDEF-ALL is non-nil, unmap all symbols and aliases first."
(interactive "p")
(when (clojure-find-ns)
(interactive "P")
(when-let ((ns (clojure-find-ns)))
(save-excursion
(goto-char (match-beginning 0))
(when undef-all
(cider-undef-all (match-string 0)))
(cider-undef-all ns))
(cider-eval-defun-at-point))))

(defun cider-read-and-eval (&optional value)
Expand Down