Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cider-jack-in: Add -XX:-OmitStackTraceInFastThrow by default #3023

Closed
wants to merge 1 commit into from
Closed

cider-jack-in: Add -XX:-OmitStackTraceInFastThrow by default #3023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cider.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ one used."
(cider-jack-in-normalized-nrepl-middlewares)
","))
(main-opts (format "\"-m\" \"nrepl.cmdline\" \"--middleware\" \"[%s]\"" middleware)))
(format "%s-Sdeps '{:deps {%s} :aliases {:cider/nrepl {:main-opts [%s]}}}' -M%s:cider/nrepl"
(format "%s-Sdeps '{:deps {%s} :aliases {:cider/nrepl {:main-opts [%s] :jvm-opts [\"-XX:-OmitStackTraceInFastThrow\"]}}}' -M%s:cider/nrepl"
(if global-options (format "%s " global-options) "")
deps-string
main-opts
Expand Down
12 changes: 8 additions & 4 deletions test/cider-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,8 @@
(let ((expected (string-join '("clojure -Sdeps '{:deps {nrepl/nrepl {:mvn/version \"0.8.3\"} "
"cider/cider-nrepl {:mvn/version \"0.25.7\"}} "
":aliases {:cider/nrepl {:main-opts [\"-m\" \"nrepl.cmdline\" \"--middleware\""
" \"[cider.nrepl/cider-middleware]\"]}}}' -M:cider/nrepl")
" \"[cider.nrepl/cider-middleware]\"] :jvm-opts [\"-XX:-OmitStackTraceInFastThrow\"]}}}' "
"-M:cider/nrepl")
"")))
(setq-local cider-allow-jack-in-without-project t)
(setq-local cider-clojure-cli-command "clojure")
Expand All @@ -385,7 +386,8 @@
(let ((expected (string-join '("clojure -Sdeps '{:deps {nrepl/nrepl {:mvn/version \"0.8.3\"} "
"cider/cider-nrepl {:mvn/version \"0.25.7\"}} "
":aliases {:cider/nrepl {:main-opts [\"-m\" \"nrepl.cmdline\" \"--middleware\""
" \"[cider.nrepl/cider-middleware]\"]}}}' -M:dev:test:cider/nrepl")
" \"[cider.nrepl/cider-middleware]\"] :jvm-opts [\"-XX:-OmitStackTraceInFastThrow\"]}}}' "
"-M:dev:test:cider/nrepl")
"")))
(setq-local cider-clojure-cli-aliases "-A:dev:test")
(setq-local cider-allow-jack-in-without-project t)
Expand All @@ -399,7 +401,8 @@
(let ((expected (string-join '("-Sdeps '{:deps {nrepl/nrepl {:mvn/version \"0.8.3\"} "
"cider/cider-nrepl {:mvn/version \"0.25.7\"}} "
":aliases {:cider/nrepl {:main-opts [\"-m\" \"nrepl.cmdline\" \"--middleware\""
" \"[cider.nrepl/cider-middleware]\"]}}}' -M:test:cider/nrepl")
" \"[cider.nrepl/cider-middleware]\"] :jvm-opts [\"-XX:-OmitStackTraceInFastThrow\"]}}}' "
"-M:test:cider/nrepl")
""))
(deps '(("nrepl/nrepl" "0.8.3"))))
(let ((cider-clojure-cli-aliases "test"))
Expand All @@ -416,7 +419,8 @@
(let ((expected (string-join '("-J-Djdk.attach.allowAttachSelf -Sdeps '{:deps {nrepl/nrepl {:mvn/version \"0.8.3\"} "
"cider/cider-nrepl {:mvn/version \"0.25.7\"}} "
":aliases {:cider/nrepl {:main-opts [\"-m\" \"nrepl.cmdline\" \"--middleware\""
" \"[cider.nrepl/cider-middleware]\"]}}}' -M:test:cider/nrepl")
" \"[cider.nrepl/cider-middleware]\"] :jvm-opts [\"-XX:-OmitStackTraceInFastThrow\"]}}}' "
"-M:test:cider/nrepl")
""))
(deps '(("nrepl/nrepl" "0.8.3"))))
(let ((cider-clojure-cli-aliases "test"))
Expand Down