[Inspector] Configure truncation limits #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdbrown
force-pushed
the
feature/inspect-display-length
branch
from
d96423c
to
78ae6b2
Compare
bbatsov
reviewed
Apr 14, 2021
| @@ -49,6 +49,12 @@ You'll have access to additional keybindings in the inspector buffer | |||
| | kbd:[s] | |||
| | Set a new page size in paginated view | |||
|
|
|||
| | kbd:[c] | |||
There was a problem hiding this comment.
I'd also mention the new defcustoms in the "Config" section. Seems we forgot to document any of the existing config options, but we should change this.
There was a problem hiding this comment.
Sounds good! I added those and a brief mention of the fill-frame setting, so all cider-inspector.el defcustoms are covered.
bbatsov
reviewed
Apr 14, 2021
cider.el
Outdated
| @@ -406,7 +406,7 @@ Elements of the list are artifact name and list of exclusions to apply for the a | |||
| (defconst cider-latest-clojure-version "1.10.1" | |||
| "Latest supported version of Clojure.") | |||
|
|
|||
| (defconst cider-required-middleware-version "0.25.10" | |||
| (defconst cider-required-middleware-version "0.26-SNAPSHOT-TODO" | |||
There was a problem hiding this comment.
Here it should be 0.26.0-SNAPSHOT
The limits after which the inspector truncates collection members are now configurable. Previously they were hardcoded to 5 and 150 for collection and atom (non-collection) members. Add keybindings to cider-inspector-mode: - a adjust atom truncation limit (default 150) - c adjust nested collection truncation limit (default 5) and add defcustoms to adjust the defaults - cider-inspector-max-atom-length - cider-inspector-max-coll-size
pdbrown
force-pushed
the
feature/inspect-display-length
branch
from
78ae6b2
to
123b220
Compare
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: adjust cider-required-middleware-version when published
The limits after which the inspector truncates collection members are now
configurable. Previously they were hardcoded to 5 and 150 for collection and
atom (non-collection) members.
Add keybindings to cider-inspector-mode:
and add defcustoms to adjust the defaults
This continues the work in clojure-emacs/cider-nrepl#694 and needs to be updated with the right cider-nrepl version number before it can merge.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)eldev lint) which is based onelisp-lintand includescheckdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.