Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cider-repl-require-repl-utils loads cljs repl utils #2674

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

rpkarlsson
Copy link
Contributor

Part of the solution for #2647, loading cljs repl utils in cljs buffers.

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • All code passes the linter (make lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

@rpkarlsson
Copy link
Contributor Author

Still looking at:

Maybe we should rename this to cider-repl-init-code-clj and add some matching cljs counterpart (or make it an alist/plist) as well, so there's some init code that we'd run in ClojureScript REPLs after they are upgraded as well.
#2647 (comment)

But still trying to figure out how to run code once upgraded to a cljs repl. In the meantime I thought I'd make a PR of the first part.

@bbatsov bbatsov merged commit 7ea9605 into clojure-emacs:master Jul 11, 2019
@bbatsov
Copy link
Member

bbatsov commented Jul 11, 2019

Thanks for tackling this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants