-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix remaining ci errors #2143
fix remaining ci errors #2143
Conversation
@xiongtx : looks like we've got some of the same fixes in here! |
Indeed, you did, and most likely better work too, as I'm still relatively new with elisp. For what it's worth, I set up Travis on my fork so I can experiment freely with fixes and watch the jobs succeed or fail before doing the pull request. Also, I have a Docker container running based on the Travis base image which gives me a way to run tests locally (and can even bind-mount my working directory so I can keep testing interactively). I'll type that up and check that in, if anyone's interested. |
Definitely sounds interesting! I've been trying to figure out the best way to test against multiple Emacs versions locally, but I always just end up leaving it to CI 😝. |
@gonewest818 I would love to see how you did the CI and docker stuff as wel |
I was amused to see both of you tackled pretty much the same issues at the same time. 😄 And I appreciate your work very much. I've opted to merged @xiongtx's PRs, as they were submitted first and the one dealing with reported problems was more detailed. |
no problem. thanks. |
The build is now green for a first time in quite a while! 🎉 🎉 🎉 Thanks, guys! You're awesome! 🏆 |
❤️ ❤️ ❤️ |
so this is a bit of a grab bag, but it fixes the remaining errors in CI so that builds actually succeed and go green. Example: https://travis-ci.org/gonewest818/cider/builds/317882617
changes: