Mark many custom variables as safe #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevereOverfl0w
force-pushed
the
bootdirlocals
branch
from
5973632
to
05edf31
Compare
|
Uhm, maybe the tests were already broken. The changes are so trivial...like this one Line 450 in 0816372 |
bbatsov
reviewed
Jul 5, 2017
CHANGELOG.md
Outdated
| @@ -34,6 +34,7 @@ | |||
| * [#1945](https://github.com/clojure-emacs/cider/pull/1945): Start nREPL servers bound to `::` by default using `cider-jack-in`. | |||
| * Renamed `cider-prompt-save-file-on-load` to `cider-save-file-on-load` and adjust its supported values accordingly (the default now is `'prompt` and `'always-save` is now simply `t`). | |||
| * [#2014](https://github.com/clojure-emacs/cider/pull/2014): Unify the format for `forms-str` and `arglists-str`. | |||
| * [#2027](https://github.com/clojure-emacs/cider/pull/2027): Mark many custom variables as safe | |||
There was a problem hiding this comment.
This sentence should end with a .. And the wording can be more specific - "Make all customs variables related to lein and boot params safe.".
SevereOverfl0w
force-pushed
the
bootdirlocals
branch
from
05edf31
to
77918c5
Compare
|
Glad it's in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on slack discussion. These variables are useful to set in a .dir-locals.el for projects.
make test) @arichiardiM-x checkdocwarnings @arichiardi