fix find-file-noselect: Wrong type argument: stringp, nil

[hojinyoo]

• fix a bug that losing buffer-file-name after call (cider--quit-error-window)
  The bug yields an error message `find-file-noselect: Wrong type argument: stringp, nil' that prevents from loading buffer.

---

Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• All tests are passing (make test)
• The new code is not generating bytecode or M-x checkdoc warnings
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the readme (if adding/changing user-visible functionality)
• You've updated the refcard (if you made changes to the commands listed there)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.

[bbatsov]

I can't really understand how moving the code as you did would fix anything. Some details would be useful.

[hojinatmixpanel]

(cider--quit-error-window) has a side-effect, at least emacs in some setup. Once the error window is "buried" by the call, the return value of function buffer-file-name becomes nil. That leads filename to be nil, and it is avoided by changing the order or moving the code.

[bbatsov]

Ah, I get it now - quitting the error buffer probably selects it. Now I understand why this fix works, but I don't think that's the best possible fix as this makes the code pretty brittle - that's going to break again the moment someone rearranges the code. I think that passing buffer to buffer-file-name is going to fix this problem in a much clear and robust manner.

[hojinyoo]

cool. that works as well.