Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cider-ns-browser to show private vars via toggle #3200

Closed
MicahElliott opened this issue May 13, 2022 · 1 comment
Closed

Enable cider-ns-browser to show private vars via toggle #3200

MicahElliott opened this issue May 13, 2022 · 1 comment
Labels
feature request good first issue A simple tasks suitable for first-time contributors

Comments

@MicahElliott
Copy link

Problem: It seems good practice to mark your non-public vars as ^:private (including fns from defn-). But then cider-ns-browser (a very useful view) doesn't show them. And it's still useful to document private vars.

Solution: Enable the private vars to be shown, with their docstrings. Could be a toggle command like a (for "show All") in the map (https://github.com/clojure-emacs/cider/blob/master/cider-browse-ns.el#L53).

Should probably still not show vars marked as ^:deprecated.
@bbatsov bbatsov added feature request good first issue A simple tasks suitable for first-time contributors labels May 15, 2022
@bbatsov
Copy link
Member

bbatsov commented May 15, 2022

Should be a relatively simple change, so PRs welcome!

zkry added a commit to zkry/cider that referenced this issue Jun 22, 2022
@zkry
[Fix clojure-emacs#3200] Add private var listing below public vars
803b360 
Adds a second "ns-vars-with-meta" nrepl call to fetch the private
variables.  Adds a new param to `cider-browse-ns--list` to be able to
provide a list of the private items and have this function format
accordingly.
zkry added a commit to zkry/cider that referenced this issue Jun 22, 2022
@zkry
[Fix clojure-emacs#3200] Add private var listing below public vars
33a6f53 
Adds a second "ns-vars-with-meta" nrepl call to fetch the private
variables.  Adds a new param to `cider-browse-ns--list` to be able to
provide a list of the private items and have this function format
accordingly.
zkry added a commit to zkry/cider that referenced this issue Jun 22, 2022
@zkry
[Fix clojure-emacs#3200] Add private var listing below public vars
0953d91 
Adds a second "ns-vars-with-meta" nrepl call to fetch the private
variables.  Adds a new param to `cider-browse-ns--list` to be able to
provide a list of the private items and have this function format
accordingly.
zkry added a commit to zkry/cider that referenced this issue Jun 22, 2022
@zkry
[Fix clojure-emacs#3200] Add private var listing below public vars
0baf908 
Adds a second "ns-vars-with-meta" nrepl call to fetch the private
variables.  Adds a new param to `cider-browse-ns--list` to be able to
provide a list of the private items and have this function format
accordingly.
zkry added a commit to zkry/cider that referenced this issue Jun 22, 2022
@zkry
[Fix clojure-emacs#3200] Add private var listing below public vars
5429fc9 
Adds a second "ns-vars-with-meta" nrepl call to fetch the private
variables.  Adds a new param to `cider-browse-ns--list` to be able to
provide a list of the private items and have this function format
accordingly.
zkry added a commit to zkry/cider that referenced this issue Jun 22, 2022
@zkry
[Fix clojure-emacs#3200] Add private var listing below public vars
a55252b 
Adds a second "ns-vars-with-meta" nrepl call to fetch the private
variables.  Adds a new param to `cider-browse-ns--list` to be able to
provide a list of the private items and have this function format
accordingly.
zkry added a commit to zkry/cider that referenced this issue Jun 22, 2022
@zkry
[Fix clojure-emacs#3200] Add private var listing below public vars
cd99f33 
Adds a second "ns-vars-with-meta" nrepl call to fetch the private
variables.  Adds a new param to `cider-browse-ns--list` to be able to
provide a list of the private items and have this function format
accordingly.
zkry added a commit to zkry/cider that referenced this issue Jun 22, 2022
@zkry
[Fix clojure-emacs#3200] Add private var listing below public vars
be11c1b 
Adds a second "ns-vars-with-meta" nrepl call to fetch the private
variables.  Adds a new param to `cider-browse-ns--list` to be able to
provide a list of the private items and have this function format
accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue A simple tasks suitable for first-time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbatsov @MicahElliott