Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling cider-company-enable-fuzzy-completion breaks helm completions #2964

Closed
arichiardi opened this issue Jan 9, 2021 · 2 comments
Closed
Labels
bug good first issue A simple tasks suitable for first-time contributors help wanted

Comments

@arichiardi
Copy link
Contributor

Expected behavior

When the REPL has not been stared, M-x and filtering command candidates should not throw an error in a cider-mode buffer with cider-company-enable-fuzzy-completion.

Actual behavior

It throws the following:

2021-01-08-182059_1920x1080_scrot

It is not really clear from the screen but the error is basically "No linked CIDER session".

Steps to reproduce the problem

Install helm (you can run it in isolation with emacs-helm.sh) and enable (cider-company-enable-fuzzy-completion).

Execute helm-M-x and try asd or anything command prefix that does not exist.

Environment & Version information

CIDER version information

latest master

Emacs version

GNU Emacs 28.0.50

Operating system

Linux


I did not have time to investigate too much but I am wondering if we the cider, completion-styles function should not throw an error when the REPL is not connected. Throwing this there but I am not sure this is the actual solution without looking into it a bit more 😄

@bbatsov bbatsov added bug help wanted good first issue A simple tasks suitable for first-time contributors labels Jan 10, 2021
brool added a commit to brool/cider that referenced this issue Jan 31, 2021
brool added a commit to brool/cider that referenced this issue Jan 31, 2021
@arichiardi
Copy link
Contributor Author

Great this is cool, thank,you!

@arichiardi
Copy link
Contributor Author

Can confirm it works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue A simple tasks suitable for first-time contributors help wanted
Projects
None yet
Development

No branches or pull requests

2 participants