-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cider won't start under Clojure 1.9.0-alpha18 #2081
Comments
Clojure 1.9.0a18 new feature
Trivial to fix, but should be done through entire cider-nrepl codebase. |
What does this mean? An example would be enlightening. |
Sorry, that's from the Clojure 1.9.0-alpha18 announcement: https://groups.google.com/d/msg/clojure/rb22V98rPLM/MFBBcz-gAQAJ I think it means you can't put a fully-qualified namespace in a double-colon keyword. E.g., this will work: (ns whatever
(:require [clojure.test :as test]))
::test/whatever But this won't: ::clojure.test/whatever I probably should have made this ticket against cider-nrepl, sorry. |
Correct - this has always worked, but not intentionally. The spec (and code) now follow the original intent. In this case, just deleting one of the colons should work as well: |
Oh, that makes sense. I didn't know |
A fixed version of |
I am sure people would appreciate them earlier but there is one small safety concern which is unlikely to affect anyone with only cider's middleware stack. Clojure seems to have troubles with loading namespaces in parallel, and loading middleware concurrently might cause issues. Moving this discussion to #2078. |
I can only confirm that this problem doesn't come up with
@bbatsov please please please do cut it! |
@bbatsov Can you cut Thanks! |
@briprowe You can always upgrade to the latest version from Melpa repository, which I believe should contain the fix: https://melpa.org/#/cider |
This also required cider-nrepl to be upgraded to 0.15.1, due to the following: clojure-emacs/cider#2081
This is still happening to me on |
Looks like the problem was my |
1.9.0-RC1 and 0.15.1 combo does work for me |
I'm still getting this error with Clojure 1.9 after updating to what I believe is the latest cider: Any ideas how to fix this?
|
My problem seems to have been caused by the lein-gorilla plugin, which is interfering with nrepl in some way. |
@Engelberg I think this is a bug that has been fixed in subsequent cider-nrepl's. it must be holding onto an old one. If its the issue I think it is, it is using a fully qualified keyword as an alias, something that is no longer valid as of clojure 1.9. |
and from its project.clj: |
Any `cider/cider-nrepl` version prior to 0.15.1 would error out if ran. This is the [exact issue](clojure-emacs/cider#2081). Bumped version fixes everything.
The versions currently listed can cause errors which prevent the REPL from starting. See clojure-emacs/cider#2081 for details. Upgrading to more current versions fixes that issue.
Trying to start Cider (via cider-jack-in) with Clojure 1.9.0-alpha18 fails.
Expected behavior
Cider launches as normal.
Actual behavior
Cider fails to launch with the following error/stack trace in *Messages*:
Presumably because of the following fix in alpha 18:
(It doesn't seem like the compiler likes
::clojure.test/once-fixtures
.Steps to reproduce the problem
lein new whatever
)1.9.0-alpha18
.cider-jack-in
.Environment & Version information
CIDER version information
I don't get as far as seeing the version string. I'm using Cider 20170729.133 installed via melpa, tools.nrepl version 0.2.12, cider-nrepl version 0.15.1-SNAPSHOT.
Lein/Boot version
Leiningen version 2.7.1
Emacs version
GNU Emacs 25.2.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911)) of 2017-04-21
Operating system
mac OS Sierra 10.12.6
The text was updated successfully, but these errors were encountered: