bump suitable to fix #643

[rksm]

• nodejs would throw nullpointer exception on first completion due to repl-env
  not being initialized

Before submitting a PR make sure the following things have been done:

• [yep] The commits are consistent with our contribution guidelines
• You've added tests to cover your change(s)
• [yep] All tests are passing
• [yep] The new code is not generating reflection warnings
• You've updated the README (if adding/changing middleware)

Note: If you're just starting out to hack on cider-nrepl you might find
nREPL's documentation and the
"Design" section of the README extremely useful.*

Thanks!

[rksm]

waiting for clojars to be up again...

[bbatsov]

Same here. :-)

[rksm]

Looking into the test errors...

[dpsutton]

I'm running the tests locally but its not related to you. :symbol was renamed to :sym and the integration tests in info_spec_test.clj need to be updated accordingly.

[rksm]

Hmm I believe there is also an issue with my fix. Apparently calling cljs.repl/setup during the completion call with a nashorn/repl-env won't produce completions somehow... looking into it.

[dpsutton]

I was incorrect. The tests fail due to upstream in orchard.meta

(defn var-meta
  "Return a map of metadata for var v.
  If whitelist is missing use var-meta-whitelist."
  ([v] (var-meta v var-meta-whitelist))
  ([v whitelist]
   (when (var? v)
     (let [meta-map (-> (meta v)
                        maybe-protocol
                        (select-keys (or whitelist var-meta-whitelist))
                        map-seq
                        maybe-add-file
                        maybe-add-url
                        (update :ns ns-name))]
       (maybe-add-spec v meta-map) ;; this spec can never be returned
       (maybe-add-see-also v meta-map)))))

[bbatsov]

@dpsutton Hmm, that's weird. I think the relevant tests were passing for me last time I checked them. I'll look into this after Clojure/south.

[bbatsov]

Hmm I believe there is also an issue with my fix. Apparently calling cljs.repl/setup during the completion call with a nashorn/repl-env won't produce completions somehow... looking into it.

Got it. Let me know when you manage to track this down.

[rksm]

So I found the root cause but don't know how to fix it yet.

cljs.repl.node uses a hand-made (not via a dynamic var but the thread name) thread-local buffer to store evaluation results (https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/repl/node.clj#L127). The thread that completions are computed in does not seem to be the same as the original thread for creating the repl env (names are something like clojure-agent-send-off-pool-11 for completion and nRepl-session-08c91d1c-7c45-4e0b-9ffd-76f6588cc4cc for initialization).

So when suitable tries to eval we hit a hard nullpointer exception. I could try to add custom code for node here but this seems just a hack on a hack. Any idea what best to do here?

[bbatsov]

Well, the way I see we either add custom code or we ignore node. I'm not the world's greatest expert in ClojureScript, though. :D

[rksm]

The issue should be fixed now.

[bbatsov]

Thanks! I'll cut a new release later today.