Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fake.class.path as classpath in Boot projects #455

Merged
merged 1 commit into from
Dec 9, 2017

Conversation

grzm
Copy link
Contributor

@grzm grzm commented Nov 29, 2017

Boot manages the classpath dynamically through filesets, so
java.class.path does not include the source paths. Boot provides
access to the original directories via the fake.class.path system
property. Use this fake.class.path property instead of
java.class.path for Boot projects.

Before submitting a PR make sure the following things have been done:

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • The new code is not generating reflection warnings
  • You've updated the readme (if adding/changing middleware)

Boot manages the classpath dynamically through filesets, so
`java.class.path` does not include the source paths. Boot provides
access to the original directories via the `fake.class.path` system
property. Use this `fake.class.path` property instead of
`java.class.path` for Boot projects.
@grzm
Copy link
Contributor Author

grzm commented Nov 29, 2017

This resolves an issue in cider clojure-emacs/cider#1651 where cider-expected-ns returns nil when running under boot.

@bbatsov bbatsov merged commit 6e0f309 into clojure-emacs:master Dec 9, 2017
@bbatsov
Copy link
Member

bbatsov commented Dec 9, 2017

👍 Nicely done!

Please, follow this up with a PR updating the CIDER changelog.

@grzm
Copy link
Contributor Author

grzm commented Dec 9, 2017

Thanks! I've submitted clojure-emacs/cider#2124

@grzm grzm deleted the boot-fake-classpath branch December 9, 2017 16:32
bbatsov pushed a commit to clojure-emacs/cider that referenced this pull request Dec 9, 2017
The actual fix is in clojure-emacs/cider-nrepl#455. This commit simply adds the bugfix to the changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants