Fix exception when instrumenting code with embedded namespace #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instrumentation would throw when trying to macroexpand code containing a namespace object with metadata. The logging macros in clojure.tools.logging embed the current namespace object into the code at macroexpansion time. Instrumenting a function that contained logging calls would throw an exception if the current namespace had metadata (eg: a docstring). This is because Namespace has the unusual property of implementing IMeta (so you can call `(meta *ns*)`), but not IObj (so `(with-meta *ns* ...)` throws).
|
👍 Good catch! Thanks! You might also want to mention this in CIDER's changelog. |
|
Thanks indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrumentation would throw when trying to macroexpand code containing a
namespace object with metadata.
The logging macros in clojure.tools.logging embed the current namespace
object into the code at macroexpansion time. Instrumenting a function
that contained logging calls would throw an exception if the current
namespace had metadata (eg: a docstring).
This is because Namespace has the unusual property of implementing
IMeta (so you can call
(meta *ns*)), but not IObj (so(with-meta *ns* ...)throws).