Upgrade to Jetty 11 #883
Merged
Upgrade to Jetty 11 #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we run in to an error starting the system during development, we may try to stop this component before it has started. This guards against errors when doing that.
This upgrades us to ring 1.11, which moves from Jetty 9 to Jetty 11. This includes using a fork of cognitect's http-client that works with Jetty 11's client impl.
This is a bit of a mystery: if we let slf4j-api come in via a transitive dependency, our logback.xml file is ignored (at least in dev & test), so all logging goes to stdout. clojure.tools.logging is finding slj4j-api in both cases, but logback does not get initialized in the case where this isn't a top-level dep. I have no idea why this is happening! Logging is terrible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make event component more resilient
If we run in to an error starting the system during development, we may
try to stop this component before it has started. This guards against
errors when doing that.
Upgrade to Jetty 11
This upgrades us to ring 1.11, which moves from Jetty 9 to Jetty 11.
This includes using a fork of cognitect's http-client that works with
Jetty 11's client impl.
Directly depend on slf4j-api
This is a bit of a mystery: if we let slf4j-api come in via a transitive
dependency, our logback.xml file is ignored (at least in dev & test), so
all logging goes to stdout. clojure.tools.logging is finding slj4j-api
in both cases, but logback does not get initialized in the case where
this isn't a top-level dep.
I have no idea why this is happening! Logging is terrible.