Implement repo directory listings #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias
force-pushed
the
tcrawley/dynamic-index-files
branch
3 times, most recently
from
732b263 to
3848520
Compare
This upgrades the s3 client from ListObjects to the newer ListObjectsV2, which will allow us to just list prefixes in the future. This also adds tests for our s3 implementation using minio in docker to ensure that the s3-specific implementation is correct.
tobias
force-pushed
the
tcrawley/dynamic-index-files
branch
from
3848520 to
3f6d005
Compare
tobias
changed the title
tobias
force-pushed
the
tcrawley/dynamic-index-files
branch
2 times, most recently
from
d51d14f to
cf72fee
Compare
This will be used to provide directory listings. This also brings the mock client closer to the real one in what it returns, and adds tests for the mock client behavior.
This will generate a list of the repo given a path prefix. This is intended to be used only via fastly for repo.clojars.org, so isn't navigable if accessed directly.
tobias
force-pushed
the
tcrawley/dynamic-index-files
branch
from
cf72fee to
65148c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #860.