-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show dependents #814
Comments
This will show other Clojars project versions that depend on the jar project version being viewed. See #814
This will show other Clojars project versions that depend on the jar project version being viewed. See #814
That's a really great idea @vemv! I went ahead and implemented it. You should now see a Potemkin is a good example: Does that work for you? |
That's amazing @tobias ! Happy to see this alive and so quickly. Personally, when visiting e.g. https://clojars.org/clj-kondo (no version in the url) I'd expect the dependents to be any dependents, regardless of the version. My reasoning is that some libraries update quite frequently, so an update shouldn't make the dependents "disappear". If visiting https://clojars.org/clj-kondo/versions/2021.10.19 (with version with the url) the algo would be more straighforward: show dependents on that specific version. I do imagine the rationale behind the current impl, i.e. if dependent x was only a dependent for a very old version, then it's not accurate to show that as a dependent forever and ever. Perhaps a middle ground algo can be worked out, e.g. A lib x is considered a dependent of lib y at version v if:
Of course sky is the limit with heuristics, probably one can start small and grow it from there. Cheers - V |
ps - there's a typo |
Thanks for the feedback @vemv! That makes sense. One issue with the route without a version is it just takes you to the latest non-SNAPSHOT version, so that page is really a version page. But I agree it would be useful to be able to see the dependents of the project, not just the version. What if, for every version, we:
Thanks! I fixed this on |
@vemv I implemented what I outlined above, please take a look and let me know what you think. |
Hey @tobias it looks very neat, kudos! I definitely see myself / others giving much use to the current impl. |
This GH feature is nice https://github.com/brettwooldridge/HikariCP/network/dependents i.e. I might be interested in knowing who depends on a given artifact.
Some use cases:
I believe GH's
dependents
feature has Clojure as sort of a second-class citizen, so having it in Clojars would seem handy. Naturally it could be placed below this section:Cheers - V
The text was updated successfully, but these errors were encountered: