Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audit logging for group membership changes #812

Closed
danielcompton opened this issue Oct 5, 2021 · 2 comments
Closed

Add audit logging for group membership changes #812

danielcompton opened this issue Oct 5, 2021 · 2 comments

Comments

@danielcompton
Copy link
Member

danielcompton commented Oct 5, 2021

I went to add someone to the org.flatland group and expected to see the action show up in the audit log. When I looked at the feature I realised the log only covers deploy actions. Would it be good to extend/add to the log concept for other actions around adding/removing members and creating tokens?

Alternatively, we could just change the copy of the header to say that it is an "Audit log for org.flatland deploys for the last 30 days"?

One other thought, do we need to limit the audit logs to the last 30 days?

Screenshot of Safari (5-10-21, 2-10-08 PM)

@tobias
Copy link
Member

tobias commented Oct 6, 2021

I agree that we should add members and tokens to the audit log - it was initially added to work around #774, and my intention was to expand it to other actions, but I haven't yet done that.

The logs are stored in postgres, and I was worried about growth, but we could remove the truncation and monitor the growth rate. I agree it would be useful to have more than 30 days of history.

tobias added a commit to clojars/infrastructure that referenced this issue Oct 9, 2021
This reverts commit cd8a835.

We aren't going to truncate audit records any longer, and will just
monitor table usage to see if we should truncate in the future.

See clojars/clojars-web#812
tobias added a commit that referenced this issue Oct 9, 2021
We no longer truncate audit logs.

See #812.
@tobias
Copy link
Member

tobias commented Oct 9, 2021

Clojars-149 now has:

  • audit logging for member addition/removal
  • no audit log truncation

@tobias tobias closed this as completed Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants