Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove target="_blank" links or sanitise them #558

Closed
danielcompton opened this issue Aug 23, 2016 · 0 comments · Fixed by #572
Closed

Remove target="_blank" links or sanitise them #558

danielcompton opened this issue Aug 23, 2016 · 0 comments · Fixed by #572
Labels
ready-for-work size:small

Comments

@danielcompton
Copy link
Member

There is a vulnerability with opening target="_blank" links without adding rel="noopener noreferrer". I'd argue we probably don't want them at all, but if we do then we should also add the rel stuff too.

https://medium.com/@jitbit/target-blank-the-most-underestimated-vulnerability-ever-96e328301f4c#.5dcfxcy6q
https://news.ycombinator.com/item?id=11631292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready-for-work size:small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove target="_blank" from a tags lfn3/clojars-web
2 participants
@tobias @danielcompton