Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module-based projects can't be fully deployed #541

Closed
tobias opened this issue Jun 27, 2016 · 0 comments
Closed

Module-based projects can't be fully deployed #541

tobias opened this issue Jun 27, 2016 · 0 comments
Labels

Comments

@tobias
Copy link
Member

tobias commented Jun 27, 2016

The atomic deploy logic doesn't properly handle the case where different artifact names are used in the same session, which will happen in a multi-module lein project (one that uses lein-modules, for example).

The failure manifests for the user as a 403 - Forbidden on the second module that is deployed.

@tobias tobias added the bug label Jun 27, 2016
tobias added a commit that referenced this issue Jun 27, 2016
lein-module based projects will share an aether session when deploying,
but we want each module to have it's own session, so they will each have
their own atomic deploy. Without this change, the second and all
subsequent module deploys will fail.

The fix here is to store the tmp repos as a seq, and find the existing
one that matches the current upload, or creating a new one if none
match. This would allow interleaving files for different artifacts in
the same session, which none of the existing tooling does, but who knows
what craziness exists out there?
@tobias tobias closed this as completed Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant