Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with Clojars dropping / ignoring some artifacts? #532

Closed
mikera opened this issue Jun 8, 2016 · 6 comments
Closed

Problem with Clojars dropping / ignoring some artifacts? #532

mikera opened this issue Jun 8, 2016 · 6 comments
Labels
bug

Comments

@mikera
Copy link

mikera commented Jun 8, 2016

Hi,

I've been hitting problems releasing core.matrix to Clojars - it seems to be dropping the test jars that previously uploaded fine. Compare:
https://clojars.org/repo/net/mikera/core.matrix/0.52.1/

With the older release:
https://clojars.org/repo/net/mikera/core.matrix/0.50.0/

As you can see, the older release included a lot more artifacts. I'm pretty sure the artifacts all got uploaded as reported by Maven:
Uploaded: https://clojars.org/repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-tests.jar (63 KB at 28.8 KB/sec)

So it appears that the Artifacts are now being dropped by Clojars at some point.
@danielcompton
Copy link
Member

This is likely related to #226, and #505. Toby is more familiar with that change.

@tobias
Copy link
Member

tobias commented Jun 9, 2016

This is indeed related to #226 and #505, and is the same root cause as #515.

We currently use the upload of maven-metadata.xml as a signal to
close the interim repo, but that's clearly not the correct thing to
do. I had assumed uploading artifacts after the maven-metadata.xml
file only occurred when using maven-deploy-plugin from the command
line, but it looks like maven always does that with classified
artifacts:

::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:04 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1.jar HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                                     
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:05 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1.jar.sha1 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                                
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:05 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1.jar.md5 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                                 
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:06 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1.pom HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                                     
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:07 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1.pom.sha1 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                                
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:07 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1.pom.md5 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                                 
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:10 +0000] "PUT /repo/net/mikera/core.matrix/maven-metadata.xml HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                                                
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:11 +0000] "PUT /repo/net/mikera/core.matrix/maven-metadata.xml.sha1 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                                           
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:11 +0000] "PUT /repo/net/mikera/core.matrix/maven-metadata.xml.md5 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                                            
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:13 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-sources.jar HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                             
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:13 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-sources.jar.sha1 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                        
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:14 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-sources.jar.md5 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                         
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:15 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-javadoc.jar HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                             
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:15 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-javadoc.jar.sha1 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                        
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:16 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-javadoc.jar.md5 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                         
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:17 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-tests.jar HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                               
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:18 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-tests.jar.sha1 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                          
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:18 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-tests.jar.md5 HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                           
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:19 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1.jar.asc HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                                 
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:19 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1.pom.asc HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                                 
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:20 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-sources.jar.asc HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:21 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-javadoc.jar.asc HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"                                                                         
::ffff:86.17.77.141 - mikera [08/Jun/2016:21:52:21 +0000] "PUT /repo/net/mikera/core.matrix/0.52.1/core.matrix-0.52.1-tests.jar.asc HTTP/1.1" 201 0 "-" "Apache-Maven/3.3.3 (Java 1.8.0_40; Windows 8.1 6.3)"

I have a fix in mind that I will try to get implemented today - sorry for the trouble.

@tobias tobias added the bug label Jun 9, 2016
tobias added a commit that referenced this issue Jun 10, 2016
@tobias
Don't ignore files uploaded after maven-metadata.xml [#515 #532]
9e2fe84 
Maven will upload *any* classified artifact after uploading
maven-metadata.xml. We use maven-metadata.xml as a trigger to know when
to finalize the deploy, moving the contents to the actual repo and to
cloudfiles. Before this change, we essentially ignored any files that
came in after the finalization. Now, any files that come in after
finalization go straight to the actual repo and to cloudfiles.

This means that deployments with classified artifacts is no longer
atomic - the primary artifact, pom, and maven-metadata.xml will be
consistent, but any classified artifacts won't be part of that atomic
unit.

This commit also switches us from clj-http-lite to clj-http for
testing, since we need cookie support to properly test this change,
since we need to control the order of deployment, so can't use aether.
@tobias
Copy link
Member

tobias commented Jun 10, 2016

I have a fix for this on master - I need to schedule a maintenance window to deploy it, since there are other changes in the pipe that require db migration. I'll try to make that happen early next week.

@mikera
Copy link
Author

mikera commented Jun 14, 2016

Awesome thanks @tobias ! Will save me a lot of time vs. having to manually copy snapshots around!

@tobias
Copy link
Member

tobias commented Jun 15, 2016

@mikera - I tried to deploy this fix earlier this week, but had to roll it back due to unrelated issues. I'm fixing those now, and hope to try again early next week.

@tobias
Copy link
Member

tobias commented Jun 21, 2016

@mikera - this should now be fixed. I deployed a fork of core.matrix, and can see the test artifacts there: https://clojars.org/repo/org/clojars/tcrawley/core.matrix/0.52.4-SNAPSHOT/

I'm closing this, but feel free to reopen if you see any issues.

@tobias tobias closed this as completed Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tobias @mikera @danielcompton