Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report to Yeller 'redeploying non snapshots is not allowed' exception #465

Closed
danielcompton opened this issue Jan 11, 2016 · 3 comments

Comments

@danielcompton
Copy link
Member

We are currently reporting redeploying non-snapshots is not allowed (see http://git.io/vO2Tg) errors to Yeller. These are not worth reporting to Yeller, as they are not exceptional, and don't indicate any error on our part. We could just ignore them, but it feels cleaner to actually work out how to not report them.

@danielcompton
Copy link
Member Author

One option would be to add a :report? false key to the ex-data map we return, but I'm not sure if this is the best approach. @tcrayford do you have any patterns for wrapping ring exceptions and ignoring some of them?

@tcrayford
Copy link
Contributor

@danielcompton right now Yeller's clients don't have a thing like that. I think the right solution here is probably to allow y'all to provide a callback that determines if Yeller sends an error or not. the JS notifier has that, and it's turned out to be very useful.

@tobias
Copy link
Member

tobias commented Jan 11, 2016

If we did use :report? false in the ex-data, we could filter that here: https://github.com/clojars/clojars-web/tree/master/src/clojars/errors.clj#L36, and wouldn't necessarily need a callback in the yeller client (though I could see how that would be generally useful).

danielcompton added a commit that referenced this issue Jan 15, 2016
Yeller doesn't need to get exceptions about redeploying non-snapshots as
this is a common user error/action, and doesn't indicate a fault in
Clojars.

Fixes #465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants