Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send exceptions to a monitoring service #351

Closed
tobias opened this issue Jun 15, 2015 · 6 comments
Closed

Send exceptions to a monitoring service #351

tobias opened this issue Jun 15, 2015 · 6 comments

Comments

@tobias
Copy link
Member

tobias commented Jun 15, 2015

Such as http://yellerapp.com/ or similar.

@danielcompton
Copy link
Member

@yellerapp is free for open source/academic work, I've asked @tcrayford about this and he'll chime in in a bit.

@tcrayford
Copy link
Contributor

Looks like clojars has been sending Yeller exceptions, but I don't see the code for that in this repo. Let me know if I can do anything for you @tobias - clojars has been great to me, and I'm happy to help in any way I can.

@tobias
Copy link
Member Author

tobias commented Jul 13, 2015

@tcrayford - I have a stash locally that reports to Yeller, I just need to clean it up and figure out where we want to manually report exceptions. I created this issue as a reminder to do just that at some point :) I'll see if I can get that pushed at least as a branch today.

tobias added a commit that referenced this issue Jul 13, 2015
@tobias
Copy link
Member Author

tobias commented Jul 13, 2015

@tcrayford - I have yeller support sitting on a branch (see above), but can't seem to make it work - exceptions that get passed to https://github.com/ato/clojars-web/tree/yeller-support/src/clojars/error_reporting.clj#L20 don't seem to make it to yeller. If I manually create a client from the repl with the same settings, it works. Would you be willing to take a look and see if there's something obvious I'm doing wrong?

You can pull the yeller-support branch, then:

export YELLER_TOKEN=<token>
lein run
curl localhost:8080/error

That should report an error to the development environment of the yeller account, but doesn't.

@tcrayford
Copy link
Contributor

@tobias Ack. That's because Yeller by default ignores exceptions sent in development or test environments - see https://github.com/yeller/yeller_java/blob/master/src/com/yellerapp/client/Reporter.java#L32 (the yeller clojure client is just a very thin wrapper around the java client).

This is on purpose - it means you can just call the client in your dev or test environments, without sending errors to Yeller (which you probably don't want anyway - usually devs make a tonne of errors whilst doing their work, and mixing that in with production errors can be real confusing).

So to fix it locally:

export YELLER_TOKEN=<token>
export YELLER_ENV=production
lein run
curl localhost:8080/error

I tested that myself and it works properly.

@tobias
Copy link
Member Author

tobias commented Jul 14, 2015

Ah, that makes perfect sense. Thanks for taking a look.

tobias added a commit that referenced this issue Jul 14, 2015
@tobias tobias closed this as completed Jul 14, 2015
swr1bm86 pushed a commit to swr1bm86/clojars-web that referenced this issue Oct 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants