Implement a solution for Issue #202 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [github issue][1] provided a simple case to demonstrate the type of read that should be able to succeed. I provided a representative test in kibit.test.check-reader to capture this desire. [1]: #202
As noted in the comments, I used [clojure.tools.namespace.parse][1] as a basis for recovering dependencies, and added a way to collect the alias values. Created the `derive-aliases-from-deps` function to create the alias-map format, and then updated `derive-aliases` implementations to use it. [1]: https://github.com/clojure/tools.namespace
|
Thanks much @tomjkidd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the check reader to address #202.
As noted in the comments, I used clojure.tools.namespace.parse as
a basis for recovering dependencies, and added a way to collect the
alias values. Created the
derive-aliases-from-depsfunction tocreate the alias-map format, and then updated
derive-aliasesimplementations to use it.