Output exception details to STDERR #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an exception occurs when running a check, output debugging details about the exception to STDERR. The Code Climate kitbit engine wraps kibit and emits issues in JSON for each check on STDOUT. Any unexpected content on STDOUT causes the engine run to fail as debugging information is expected on STDERR. This small patch moves the output of debugging information to to STDERR.
|
To clarify, you only want Kibit analysis results on STDOUT, and everything else on STDERR? https://github.com/jonase/kibit/blob/0fd16aee8037db09cfb9e6d27be31dad17f14e3f/src/kibit/reporters.clj prints to STDOUT, but I don't think that's a problem here? |
|
@danielcompton That's correct. We expect reports to print to STDOUT, but other debugging details such as exception details to print to STDERR. |
danielcompton
added a commit
that referenced
this pull request
Feb 29, 2016
…tions Output exception details to STDERR
|
Cool, merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exception occurs when running a check, output debugging details
about the exception to STDERR.
The Code Climate kitbit engine wraps kibit and emits issues in JSON
for each check on STDOUT. Any unexpected content on STDOUT causes the
engine run to fail as debugging information is expected on STDERR.
This small patch moves the output of debugging information to to
STDERR.