New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kebab-casing should work in multicursor completion #95

Open

action-hong wants to merge 1 commit into clinyong:master from action-hong:master

action-hong commented Jun 15, 2024

When using multiple cursors to complete kebab-case class names, only the first line removes the "." , while other lines still retain the ".".

According to the discussion, additionalTextEdits do not affect other lines.

Since additional text edits are "precise", e.g. naming a range and text, we cannot multiply them with each cursor location. However, the main edit of a completion will be applied for each cursor. So, ideally the c++ extension doesn't need additional text edits for this.

Therefore, instead of using additionalTextEdits, we set the range directly to include the "." for replacement.


          fix: kebab-casing should work in multicursor completion

f19a23e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet