[Maps] update map name in breadcrumb when changed (elastic#34287) (el…

…astic#34361)
clintandrewhall · Apr 2, 2019 · 1d8ee92 · 1d8ee92
1 parent 379dc9f
commit 1d8ee92
Showing 1 changed file with 15 additions and 8 deletions.
diff --git a/x-pack/plugins/maps/public/angular/map_controller.js b/x-pack/plugins/maps/public/angular/map_controller.js
@@ -51,7 +51,7 @@ const app = uiModules.get('app/maps', []);
 
 app.controller('GisMapController', ($scope, $route, config, kbnUrl, localStorage, AppState, globalState, Private) => {
 
-  const savedMap = $scope.map = $route.current.locals.map;
+  const savedMap = $route.current.locals.map;
   let unsubscribe;
 
   const store = createMapStore();
@@ -203,13 +203,18 @@ app.controller('GisMapController', ($scope, $route, config, kbnUrl, localStorage
     }
   });
 
-  // TODO subscribe to store change and change when store updates title
-  chrome.breadcrumbs.set([
-    { text: i18n.translate('xpack.maps.mapController.mapsBreadcrumbLabel', {
-      defaultMessage: 'Maps'
-    }), href: '#' },
-    { text: $scope.map.title }
-  ]);
+  const updateBreadcrumbs = () => {
+    chrome.breadcrumbs.set([
+      {
+        text: i18n.translate('xpack.maps.mapController.mapsBreadcrumbLabel', {
+          defaultMessage: 'Maps'
+        }),
+        href: '#'
+      },
+      { text: savedMap.title }
+    ]);
+  };
+  updateBreadcrumbs();
 
   addHelpMenuToAppChrome(chrome);
 
@@ -243,6 +248,8 @@ app.controller('GisMapController', ($scope, $route, config, kbnUrl, localStorage
         'data-test-subj': 'saveMapSuccess',
       });
 
+      updateBreadcrumbs();
+
       if (savedMap.id !== $route.current.params.id) {
         $scope.$evalAsync(() => {
           kbnUrl.change(`map/{{id}}`, { id: savedMap.id });