Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental doctor --check flag #191

Closed
wants to merge 1 commit into from
Closed

Experimental doctor --check flag #191

wants to merge 1 commit into from

Conversation

goto-bus-stop
Copy link
Contributor

Requires clinicjs/node-clinic-doctor#273

Prints analysis result to CLI and exits with 0 in case of no issue, 1 in case of yes issue.

Check an existing profile:

clinic doctor --check .clinic/1234.clinic-doctor

Run a new profile and check:

clinic doctor --autocannon / --check -- node server

jasnell
jasnell approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a good start on this and enough to get it landed. I think possibly some additional formatting and maybe even an ascii art rendering of any red graphs would be worthwhile, even if only abbreviated. That can definitely come later tho

@goto-bus-stop
Copy link
Contributor Author

Superseded by #245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goto-bus-stop @jasnell