Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variable solar irradiance factor #27

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Conversation

brian-rose
Copy link
Collaborator

@brian-rose brian-rose commented Jan 17, 2025

Closes #26

This PR will add support for arrays of values for input parameter adjes (same dimensions as coszen).

To do:

  • Create a multi-column RRTMG_SW test with scalar adjes (it should pass, we should have this test already but don't)
  • Give that test a non-scalar value of adjes (it should fail)
  • Modify whichever layers of fortran code are needed to support array values for adjes
  • Make sure the test is passing.

@brian-rose brian-rose marked this pull request as ready for review January 17, 2025 23:00
@brian-rose brian-rose merged commit f49fa9c into climlab:main Jan 17, 2025
8 checks passed
@brian-rose brian-rose deleted the adjes branch January 17, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow array values for solar irradiance factor adjes
1 participant