Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ugwp v0 v1 combined mike #5

Closed
wants to merge 2 commits into from
Closed

Ugwp v0 v1 combined mike #5

wants to merge 2 commits into from

Conversation

mdtoy
Copy link

@mdtoy mdtoy commented Jan 27, 2021

Dom,

The main change is that I removed calls to ugwp_v1 subroutines from unified_ugwp.F90. So now, it only unifies ugwp_v0 and gsl_drag_suite. This didn't fix the problem with the name conflicts, so I renamed some of Valery's modules, for example, "ugwp_common" became "ugwpv1_common".

Unfortunately, the code still does not compile for the combination of both ugwp_unified and ugwpv1_gsldrag suites. I'll follow up with an e-mail about what I think still needs to be done.

-- Mike

@mdtoy mdtoy requested a review from climbfuji as a code owner January 27, 2021 06:20
@climbfuji climbfuji closed this Jan 29, 2021
climbfuji added a commit that referenced this pull request Feb 11, 2021
@climbfuji
Squashed commit of the following:
fdf79db 
commit 107b22d
Merge: 43e0e38 73f9f09
Author: Dustin Swales <[email protected]>
Date:   Thu Mar 5 21:07:31 2020 +0000

    Merge branch 'dtc/develop' of https://github.com/NCAR/ccpp-physics into rrtmgp-dev2

commit 43e0e38
Author: Dustin Swales <[email protected]>
Date:   Thu Feb 27 15:49:56 2020 -0700

    Try adding many mpi_barrier commands

commit 36de8f5
Author: Dustin Swales <[email protected]>
Date:   Thu Feb 27 13:55:27 2020 -0700

    Added mpi_bast commands back in

commit 75fdb61
Author: Dustin Swales <[email protected]>
Date:   Wed Feb 19 15:16:15 2020 -0700

    Reverted some changes

commit 93ae6cb
Author: Dustin Swales <[email protected]>
Date:   Wed Feb 19 14:59:09 2020 -0700

    Removed deprecated files.

commit 0e954b7
Author: Dustin Swales <[email protected]>
Date:   Wed Feb 19 14:57:25 2020 -0700

    Removed my login credential from .gitmodules.

commit 244d3ef
Author: Dustin Swales <[email protected]>
Date:   Wed Feb 19 14:54:07 2020 -0700

    Reverted some changes.

commit e201f08
Author: Dustin Swales <[email protected]>
Date:   Wed Feb 19 10:25:45 2020 -0700

    Cleaned up rrtmgp_lw_pre.F90

commit 1d92cfa
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 18 15:54:04 2020 -0700

    Reverted changes to GFS_rrtmgp_sw_pre.F90

commit b57ebfd
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 18 14:49:30 2020 -0700

    Revert earleir change.

commit ab6c12e
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 18 14:23:43 2020 -0700

    Switch back hprime to hprime(:,1)

commit 12acbb0
Merge: c5ba6f9 6d55230
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 18 14:05:21 2020 -0700

    Merge branch 'rrtmgp-dev2' of https://github.com/dustinswales/ccpp-physics into rrtmgp-dev2-no-mpi_bcast

commit 6d55230
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 18 14:04:49 2020 -0700

    Chnaged intent of lw_cloud_optical_props

commit a3cd7db
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 18 13:32:51 2020 -0700

    Remove using gas switches.

commit c5ba6f9
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 18 13:31:15 2020 -0700

    Remove using gas switches.

commit c47706b
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 18 12:25:32 2020 -0700

    changed variable name.

commit 723f740
Merge: 596229b c1bf1ae
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 18 11:58:18 2020 -0700

    Merge branch 'rrtmgp-dev2' of https://github.com/dustinswales/ccpp-physics into rrtmgp-dev2-no-mpi_bcast

commit c1bf1ae
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 18 11:57:44 2020 -0700

    Try using 1D hprime

commit 596229b
Merge: 9c682fc c984e90
Author: Dustin Swales <[email protected]>
Date:   Fri Feb 14 16:56:36 2020 -0700

    Merge branch 'rrtmgp-dev2' of https://github.com/dustinswales/ccpp-physics into rrtmgp-dev2-no-mpi_bcast

commit c984e90
Author: Dustin Swales <[email protected]>
Date:   Fri Feb 14 16:54:38 2020 -0700

    Cleaned up a tad.

commit 9c682fc
Merge: c2eb222 54a38d9
Author: Dustin Swales <[email protected]>
Date:   Wed Feb 12 10:45:23 2020 -0700

    Merge branch 'rrtmgp-dev2' of https://github.com/dustinswales/ccpp-physics into rrtmgp-dev2-no-mpi_bcast

commit 54a38d9
Author: Dustin Swales <[email protected]>
Date:   Wed Feb 12 10:43:24 2020 -0700

    Removed cloud-fraction rounding. Was using for debugging purposes.

commit b1e111f
Author: Dustin Swales <[email protected]>
Date:   Wed Feb 12 10:39:01 2020 -0700

    Reverted recent change.

commit 6473891
Author: Dustin Swales <[email protected]>
Date:   Wed Feb 12 09:48:51 2020 -0700

    Reverted some local changes.

commit 8d42056
Merge: 75c479d 01ed01f
Author: Dustin Swales <[email protected]>
Date:   Wed Feb 12 09:29:47 2020 -0700

    Merge branch 'master' of https://github.com/NCAR/ccpp-physics into rrtmgp-dev2

commit c2eb222
Merge: 3aa8cd4 75c479d
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 11 15:16:01 2020 -0700

    Merge branch 'rrtmgp-dev2' of https://github.com/dustinswales/ccpp-physics into rrtmgp-dev2-no-mpi_bcast

    Conflicts:
    	physics/rrtmgp_lw_cloud_optics.F90
    	physics/rrtmgp_sw_cloud_optics.F90

commit 75c479d
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 11 15:13:34 2020 -0700

    Updated interface to rte-rrtmgp routines.

commit 30b5237
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 11 11:09:46 2020 -0700

    Updated submodule

commit 3aa8cd4
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 11 11:08:25 2020 -0700

    Updated submodule

commit c1cec11
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 11 10:57:40 2020 -0700

    Switched to rte-rrtmgp dtc/branch.

commit 3491dcd
Author: Dustin Swales <[email protected]>
Date:   Tue Feb 11 10:55:46 2020 -0700

    Switched to rte-rrtmgp dtc/branch.

commit b67bc2d
Author: Dustin Swales <[email protected]>
Date:   Mon Feb 10 16:34:52 2020 -0700

    Removed mpi calls during initialization. Reading data ona ll processors. Started from 3dfb4c9

commit 3dfb4c9
Author: Dustin Swales <[email protected]>
Date:   Mon Feb 10 16:27:32 2020 -0700

    Cleaned up _init routines.

commit d351789
Author: Dustin Swales <[email protected]>
Date:   Thu Jan 30 15:47:43 2020 -0700

    Move allocation statement into master processor only.

commit e7c6c8e
Author: Dustin Swales <[email protected]>
Date:   Thu Jan 30 15:24:37 2020 -0700

    Try different broadcast call for character arrays.

commit be43ed8
Author: Dustin Swales <[email protected]>
Date:   Thu Jan 30 14:46:01 2020 -0700

    Added a second mpi barrier.

commit 33158c7
Author: Dustin Swales <[email protected]>
Date:   Thu Jan 30 14:09:54 2020 -0700

    Added mpi barrier. communicator working, i think.

commit 3e79d02
Author: Dustin Swales <[email protected]>
Date:   Thu Jan 30 13:27:36 2020 -0700

    Move allocation statements.

commit 09b3c3b
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 28 14:09:37 2020 -0700

    Added print statements to Thompson init routines.

commit ab612f4
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 28 12:44:25 2020 -0700

    More diagnostic print statements.

commit af24b71
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 28 12:03:10 2020 -0700

    Added some diagnostic print statements. Remvoe barrier commands.

commit e40e0f5
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 28 11:40:53 2020 -0700

    Added some diagnostic print statements.

commit d42469b
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 28 11:12:32 2020 -0700

    Change data type to double-precision.

commit 28269a9
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 28 10:35:04 2020 -0700

    Modification to LW gas optics init(). One more time.

commit c5ce144
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 28 10:05:25 2020 -0700

    Modification to LW gas optics init(). Add mpi_barrier

commit f6c4e82
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 28 09:33:50 2020 -0700

    Modification to LW gas optics init().

commit f38ef59
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 27 16:26:39 2020 -0700

    Some changes to MPI calls in inti() routines.

commit bb03ad3
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 27 15:47:19 2020 -0700

    Omission from previous commit.

commit 28243f1
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 27 15:25:20 2020 -0700

    Remove bcast condition on precision.

commit 01725b4
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 27 14:48:48 2020 -0700

    Omission from previous commit.

commit c0aab42
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 27 14:18:20 2020 -0700

    Some changes to MPI calls in inti() routines. New grouping.

commit fbb009f
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 27 12:36:55 2020 -0700

    Some changes to MPI calls in inti() routines. Again and again...

commit 6e0c346
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 27 11:01:50 2020 -0700

    Some changes to MPI calls in inti() routines. Again...

commit 0992def
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 27 10:21:38 2020 -0700

    Some changes to MPI calls in inti() routines.

commit dd9d5ce
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 21 15:54:36 2020 -0700

    Removed diagnostic print statements.

commit 320907f
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 21 15:43:21 2020 -0700

    Bug fix.

commit 64691a6
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 14 10:54:02 2020 -0700

    Added by-band lw fluxes to diagnostic output. New namelist parameter for RRTMGP: number of gaussian angles for quadrature calculation.

commit 6c8ecdd
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 13 12:49:13 2020 -0700

    Try overwriting cloud optical depth in bands1-2.

commit 5812151
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 7 11:21:44 2020 -0700

    Added some more diagnostics.

commit 203cd4a
Author: Dustin Swales <[email protected]>
Date:   Tue Jan 7 10:08:21 2020 -0700

    Needed to add MPI commands to open diagnostic output file.

commit b679203
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 6 14:40:49 2020 -0700

    Fixed error in previous commit.

commit 04ad9ed
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 6 13:40:06 2020 -0700

    Added longitude/latitude to output stream. Needed to sort through MPI output.

commit 5542aca
Author: Dustin Swales <[email protected]>
Date:   Mon Jan 6 11:22:38 2020 -0700

    Added diagnostics for LW clouds.

commit ec093b2
Author: Dustin Swales <[email protected]>
Date:   Fri Jan 3 14:58:39 2020 -0700

    Reverted some recent changes.

commit 323e6f9
Author: Dustin Swales <[email protected]>
Date:   Fri Jan 3 14:17:52 2020 -0700

    Added number_of_gaussian angles to LW calculation.

commit a564c8b
Author: Dustin Swales <[email protected]>
Date:   Thu Jan 2 12:02:56 2020 -0700

    Moved aggregation into conditional loop. LW only.

commit 2e161eb
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 31 11:34:47 2019 -0700

    Moved GFS_rrtmgp_lw_pre.F90 to rrtmgp_lw_pre.F90

commit edcb672
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 31 08:47:37 2019 -0700

    Added diffusivity angle adjustment to LW.

commit 28bea10
Author: Dustin Swales <[email protected]>
Date:   Thu Dec 19 16:00:00 2019 -0700

    Removed diagnostic cloud outputs.

commit b2d42f3
Author: Dustin Swales <[email protected]>
Date:   Thu Dec 19 14:20:35 2019 -0700

    Fix rounding error in G cloud-sampling test. Add diagnostics for cloud microphysics

commit 4d3515d
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 17 11:08:09 2019 -0700

    Round cloud-fractions to avoid McICA sampling error. In RRTMG as well.

commit 5b02c9e
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 17 10:18:24 2019 -0700

    Round cloud-fractions to avoid McICA sampling error.

commit e30305d
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 16 15:53:19 2019 -0700

    Fixed error in .meta file.

commit 1526e7d
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 16 14:10:54 2019 -0700

    Treat surface albedo exactly as in RRTMG. For SW bands 1-9, use nIR; For band 10, use average of nIR and uvVIS; For bands 11-24, use uvVIS.

commit e105f48
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 16 13:50:35 2019 -0700

    Revert "Delta-scale SW before incrementing aerosol optics."

    This reverts commit 122a750.

commit 81abe37
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 16 13:50:10 2019 -0700

    Revert "Revert "Removed MPI for testing in UFS.""

    This reverts commit 8c5ead8.

commit 8c5ead8
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 16 13:48:41 2019 -0700

    Revert "Removed MPI for testing in UFS."

    This reverts commit 4dcb001.

commit 122a750
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 16 12:29:31 2019 -0700

    Delta-scale SW before incrementing aerosol optics.

commit 4dcb001
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 16 11:56:21 2019 -0700

    Removed MPI for testing in UFS.

commit 86a2482
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 16 11:04:06 2019 -0700

    Fixed MPI calls in lw cloud optics.

commit 8c46c34
Author: Dustin Swales <[email protected]>
Date:   Fri Dec 13 15:10:42 2019 -0700

    Some more cleanup and documenting. Added initialization routine for cloud-sampling routines.

commit 0ea0a12
Author: Dustin Swales <[email protected]>
Date:   Fri Dec 13 13:44:15 2019 -0700

    Turned MPI on for rrtmgp gas-optics, omission from last commit.

commit 9ec9667
Author: Dustin Swales <[email protected]>
Date:   Fri Dec 13 13:05:16 2019 -0700

    Turned MPI on for rrtmgp gas-optics

commit 1943d14
Author: Dustin Swales <[email protected]>
Date:   Fri Dec 13 09:53:55 2019 -0700

    Removed all instances of GFS derived data types from rrtmgp scheme level code.

commit def30ce
Author: Dustin Swales <[email protected]>
Date:   Thu Dec 12 17:09:10 2019 -0700

    Started removing GFS DDTs from RRTMGP scheme.

commit 9a47ad3
Author: Dustin Swales <[email protected]>
Date:   Thu Dec 12 14:19:48 2019 -0700

    Added aerosol and cloud-sampling schemes.

commit 9bd2dbb
Author: Dustin Swales <[email protected]>
Date:   Wed Dec 11 16:07:46 2019 -0700

    Express layer-thinkness in meters?

commit ddebe45
Author: Dustin Swales <[email protected]>
Date:   Wed Dec 11 14:33:40 2019 -0700

    Alebdos (nIR and uvvis) are being averaged in rrtmg, did same in rrtmgp. Sneaky

commit ac6d7a5
Author: Dustin Swales <[email protected]>
Date:   Wed Dec 11 10:38:43 2019 -0700

    Moved some interstitial firelds out of GFS_interstitial_type into flat fields.

commit b16c6c7
Author: Dustin Swales <[email protected]>
Date:   Wed Dec 11 09:19:43 2019 -0700

    Removed MPI calls.

commit 6cdd545
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 10 15:25:31 2019 -0700

    Try calling mpi_barrier just before gas_optics%load

commit a59b898
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 10 14:46:50 2019 -0700

    Added some print statements

commit 92817d2
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 10 13:56:38 2019 -0700

    Removed mpi calls in lw gas optics. Test reading in data on all processors.

commit dcb8e46
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 10 11:05:25 2019 -0700

    Add print statements, check LW optical-depth on all processors.

commit 782ecb0
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 10 10:12:41 2019 -0700

    Reverted broadcast call for scalars

commit 25974eb
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 10 09:49:32 2019 -0700

    Cleaned up, added some diagnostics to test MPI in UFS.

commit 229ca59
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 9 16:25:31 2019 -0700

    Revert to original mpi_bcast for character arrays.

commit 0a726fd
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 9 16:02:30 2019 -0700

    Try using string length provided in file for broadcsting strings.

commit a25d714
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 9 15:21:43 2019 -0700

    Changed MPI_BCAST() for character arrays.

commit 7209345
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 9 14:34:52 2019 -0700

    Add mpi_barrier() calls to all initialization routines

commit e858d73
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 9 13:39:57 2019 -0700

    Add mpi_barrier() calls to SW gas optics initialization routine

commit fbd398f
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 9 12:17:02 2019 -0700

    Added ifdef(mpi) around declaration in initialization routines.

commit 1bc898d
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 9 11:56:26 2019 -0700

    Added some print statements to diagnose MPI init.

commit f471f79
Author: Dustin Swales <[email protected]>
Date:   Mon Dec 9 11:49:32 2019 -0700

    Added some print statements to diagnose MPI init.

commit 26cc6b1
Author: Dustin Swales <[email protected]>
Date:   Fri Dec 6 11:00:33 2019 -0700

    Cleaned up daytime masking in SW calculation

commit e93fc1b
Author: Dustin Swales <[email protected]>
Date:   Thu Dec 5 15:05:11 2019 -0700

    Some housekeeping

commit e905e96
Author: Dustin Swales <[email protected]>
Date:   Thu Dec 5 13:59:49 2019 -0700

    Add loop over solar scaling

commit 71b6a37
Author: Dustin Swales <[email protected]>
Date:   Wed Dec 4 12:43:32 2019 -0700

    Change to diagnostic outputs for RRTMGP.

commit 993508d
Merge: f895fc0 10191cd
Author: dustinswales <[email protected]>
Date:   Wed Dec 4 09:51:31 2019 -0700

    Merge pull request #9 from dustinswales/rrtmgp-dev

    Created new rrtmgp-dev(2) branch. Something got corrupted.

commit 10191cd
Merge: c62f631 7041bd2
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 3 12:12:55 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/ccpp-physics into rrtmgp-dev

commit c62f631
Merge: 2752142 0f796d9
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 3 19:04:48 2019 +0000

    Merge branch 'rrtmgp-dev' of https://github.com/dustinswales/ccpp-physics into rrtmgp-dev

commit 2752142
Author: Dustin Swales <[email protected]>
Date:   Tue Dec 3 19:03:57 2019 +0000

    Cleaned up a tad. Added some diagnostics for debuggind in SCM.

commit 0f796d9
Merge: d2799f4 904a433
Author: Dustin Swales <[email protected]>
Date:   Wed Nov 20 16:19:04 2019 -0700

    Merge branch 'master' of https://github.com/NCAR/ccpp-physics into rrtmgp-dev

commit d2799f4
Merge: 50b82a5 a7c38a6
Author: Dustin Swales <[email protected]>
Date:   Wed Nov 20 15:53:00 2019 -0700

    Merge branch 'dtc/develop' of https://github.com/NCAR/ccpp-physics into rrtmgp-dev

commit 50b82a5
Author: Dustin Swales <[email protected]>
Date:   Wed Nov 20 10:50:34 2019 -0700

    Delta-scaling added to SW calculation.

commit 54e0066
Author: Dustin Swales <[email protected]>
Date:   Thu Nov 7 10:59:19 2019 -0700

    Added solar constant adjustment factor to incident SW TOA flux. GP SW downward fluxes now agree with baseline G downward fluxes.

commit 69bf621
Merge: b7aa280 59717c5
Author: Dustin Swales <[email protected]>
Date:   Tue Nov 5 12:01:04 2019 -0700

    Merge remote branch 'grant-fork/cires_ugwp_namelist_fix' into rrtmgp-dev

commit b7aa280
Merge: b6cc944 78a8ed2
Author: Dustin Swales <[email protected]>
Date:   Tue Nov 5 10:03:44 2019 -0700

    Merge branch 'rrtmgp-dev' of https://github.com/dustinswales/ccpp-physics into rrtmgp-dev

commit 78a8ed2
Author: Dustin Swales <[email protected]>
Date:   Mon Nov 4 23:19:06 2019 +0000

    Made some changes. Moved fields into Interstitial type. Results still differ from baseline RRTMG.

commit b6cc944
Merge: 1f57f68 fe6c9ae
Author: Dustin Swales <[email protected]>
Date:   Fri Nov 1 10:35:35 2019 -0600

    Merge branch 'rrtmgp-dev' of https://github.com/dustinswales/ccpp-physics into rrtmgp-dev

commit fe6c9ae
Author: Dustin Swales <[email protected]>
Date:   Tue Oct 29 14:17:19 2019 +0000

    Moved RRTMGP active gases from GFS_radtend_type to GFS_control_type.

commit 1f57f68
Merge: f35effe cfafb29
Author: Dustin Swales <[email protected]>
Date:   Mon Oct 28 11:05:42 2019 -0600

    Merge branch 'gmtb/develop' of https://github.com/NCAR/ccpp-physics into rrtmgp-dev

commit f35effe
Author: Dustin Swales <[email protected]>
Date:   Fri Oct 25 22:06:21 2019 +0000

    Some more changes in MPI commands within initialization

commit 6126278
Author: Dustin Swales <[email protected]>
Date:   Fri Oct 25 17:32:46 2019 +0000

    Fixed typo in MPI_BCAST() calls

commit 2f23b93
Author: Dustin Swales <[email protected]>
Date:   Thu Oct 17 19:11:05 2019 +0000

    Remove deprecated code

commit 04bdd4f
Author: Dustin Swales <[email protected]>
Date:   Thu Oct 17 18:18:28 2019 +0000

    Modified calls to radiaiton routines.

commit 816ba3f
Author: Dustin Swales <[email protected]>
Date:   Wed Oct 16 22:30:12 2019 +0000

    Fixed a bug

commit 8bb1e85
Merge: 0b79698 9d6dd01
Author: Dustin Swales <[email protected]>
Date:   Tue Oct 15 18:19:58 2019 +0000

    Synced w/ upstream gmtb/develop

commit 0b79698
Author: Dustin Swales <[email protected]>
Date:   Wed Oct 9 18:01:33 2019 +0000

    Switched rte-rrtmgp submodule bracnh

commit ac30064
Author: Dustin Swales <[email protected]>
Date:   Wed Oct 9 17:54:02 2019 +0000

    updated .gitmodules

commit eba4af6
Author: Dustin Swales <[email protected]>
Date:   Wed Oct 9 17:38:22 2019 +0000

    Added RRTMGP as submodule

commit 209b572
Merge: 87d19cf ecb641e
Author: dustinswales <[email protected]>
Date:   Wed Oct 9 11:14:24 2019 -0600

    Merge pull request #8 from NCAR/gmtb/develop

    Sync with upstream Gmtb/develop

commit 87d19cf
Merge: 4520c5d 9d6b208
Author: dustinswales <[email protected]>
Date:   Wed Oct 9 10:57:16 2019 -0600

    Merge pull request #7 from dustinswales/master

    Sync with master

commit 9d6b208
Merge: 77bfcc2 ce641c9
Author: dustinswales <[email protected]>
Date:   Wed Oct 9 10:55:46 2019 -0600

    Merge pull request #6 from NCAR/master

    Sync with upstream master

commit 4520c5d
Merge: 5ebe4c0 3958a87
Author: Dustin Swales <[email protected]>
Date:   Tue Oct 8 20:15:13 2019 +0000

    Merge branch 'rrtmgp-dev' of https://github.com/dustinswales/ccpp-physics into rrtmgp-dev

commit 3958a87
Author: Dustin Swales <[email protected]>
Date:   Mon Oct 7 15:06:55 2019 -0600

    Changes were made to use RRTMGP for SW calculation, and RRTMG for the LW calculation.

commit 34d5fe1
Author: Dustin Swales <[email protected]>
Date:   Thu Sep 26 14:22:39 2019 -0600

    Working

commit e35f1b9
Merge: 4b61376 5cb9f93
Author: dustinswales <[email protected]>
Date:   Wed Sep 25 09:17:22 2019 -0600

    Merge pull request #5 from grantfirl/ticket_2050

    Ticket 2050 fix

commit 5cb9f93
Author: Grant Firl <[email protected]>
Date:   Tue Sep 24 17:59:06 2019 -0600

    change RRTMGP scheme metadata to use instances of DDTs rather than the type definition

commit 4b61376
Author: Dustin Swales <[email protected]>
Date:   Tue Sep 24 16:29:48 2019 -0600

    Getting closer...

commit f5562ee
Author: Dustin Swales <[email protected]>
Date:   Tue Sep 24 09:55:14 2019 -0600

    Fixed some bugs in argument tables.

commit c668a6a
Author: Dustin Swales <[email protected]>
Date:   Mon Sep 23 10:56:22 2019 -0600

    Modified arg_tables. Added .meta files

commit 2ead727
Author: Dustin Swales <[email protected]>
Date:   Thu Sep 19 11:54:25 2019 -0600

    Update .gitignore

commit d6946ed
Author: Dustin Swales <[email protected]>
Date:   Thu Sep 19 11:40:36 2019 -0600

    Updated rrtmgp external

commit fa9b30e
Merge: 206a950 77bfcc2
Author: Dustin Swales <[email protected]>
Date:   Thu Sep 19 11:31:35 2019 -0600

    Merge branch 'master' into rrtmgp-dev

commit 77bfcc2
Merge: be12710 12c416a
Author: dustinswales <[email protected]>
Date:   Thu Sep 19 11:23:28 2019 -0600

    Merge pull request #1 from NCAR/master

    Sync master branch of local fork with NCAR/ccpp-physics

commit 5ebe4c0
Merge: 7f8fc0b 243abfc
Author: Dustin Swales <[email protected]>
Date:   Mon Jul 1 18:23:43 2019 +0000

    Synced w/ NCAR/ccpp-physics:master

commit 7f8fc0b
Author: Dustin Swales <[email protected]>
Date:   Mon Jul 1 18:13:46 2019 +0000

    Correction to MPI calls.

commit f7915b9
Author: Dustin Swales <[email protected]>
Date:   Thu Jun 27 18:16:17 2019 +0000

    Synced with NCAR repo.

commit fa05574
Author: Dustin Swales <[email protected]>
Date:   Wed Jun 26 21:50:30 2019 +0000

    Added rte-rrtmgp repository.

commit 206a950
Author: Dustin Swales <[email protected]>
Date:   Mon Jun 24 12:17:11 2019 -0600

    Added piece for GFDL MP. Not curretnly exercised.

commit 0a100cb
Merge: c445658 be12710
Author: Dustin Swales <[email protected]>
Date:   Thu Jun 20 11:32:45 2019 -0600

    Synced w/ master/

commit c445658
Author: Dustin Swales <[email protected]>
Date:   Thu Jun 20 09:23:00 2019 -0600

    Fixed a few bugs, some housekeeping.

commit 9e5405c
Author: Dustin Swales <[email protected]>
Date:   Thu Jun 13 16:29:43 2019 -0600

    Fixed indexing error for output fluxes.

commit c9a357a
Author: Dustin Swales <[email protected]>
Date:   Wed Jun 12 09:39:56 2019 -0600

    Added calls to compute_bc() in LW and SW gas_optics. Small bug found in mo_compute_bc. Work in progress.

commit 044c880
Author: Dustin Swales <[email protected]>
Date:   Tue Jun 11 09:28:20 2019 -0600

    Renamed two modules.

commit b882dff
Author: Dustin Swales <[email protected]>
Date:   Mon Jun 10 17:17:06 2019 -0600

    Added gas_optics_sw_run() and gas_optics_lw_run() routines.

commit 52cb3a0
Author: Dustin Swales <[email protected]>
Date:   Fri Jun 7 11:33:25 2019 -0600

    Fixed potential issue in Thompson MP scheme. Cleaned up a tad.

commit 893ce88
Author: Dustin Swales <[email protected]>
Date:   Thu Jun 6 16:16:17 2019 -0600

    Some housekeeping.

commit 6e2c8bd
Author: Dustin Swales <[email protected]>
Date:   Thu Jun 6 10:24:02 2019 -0600

    Some cleaning up since last commit.

commit a4bdffe
Author: Dustin Swales <[email protected]>
Date:   Wed Jun 5 16:45:48 2019 -0600

    Major reorganization. Added schemes for cloud-optics and gas optics. Added RRTMGP active gases to gfs_physics_nml.

commit f86636b
Author: Dustin Swales <[email protected]>
Date:   Mon Jun 3 16:25:05 2019 -0600

    Split up init into gas and cloud _init routines. Renamed some variables to be more clear.

commit 4e0cfc8
Author: Dustin Swales <[email protected]>
Date:   Fri May 31 15:27:09 2019 -0600

    Added back option to call RRTMG cloud_optics().

commit 57be551
Author: Dustin Swales <[email protected]>
Date:   Fri May 31 14:25:56 2019 -0600

    Added new GFS_rrtmgp_XX_post.F90 for both SW and LW.

commit ef4ed60
Author: Dustin Swales <[email protected]>
Date:   Fri May 31 11:54:56 2019 -0600

    Moved microphysics from GFS_rrtmgp_pre_run() into its own routine, cloud_microphysics().

commit f5dc37a
Author: Dustin Swales <[email protected]>
Date:   Thu May 30 16:46:06 2019 -0600

    Remover extra-layer from GFS_rrtmgp_pre_run().

commit 1386e58
Author: Dustin Swales <[email protected]>
Date:   Wed May 29 17:05:59 2019 -0600

    More organizational changes to RRTMGP.

commit 129b829
Author: Dustin Swales <[email protected]>
Date:   Tue May 28 10:04:25 2019 -0600

    In progress...

commit a60e1e1
Author: Dustin Swales <[email protected]>
Date:   Tue May 21 16:23:01 2019 -0600

    RRTMGP DDTs working!

commit 9157959
Author: Dustin Swales <[email protected]>
Date:   Thu May 16 17:29:33 2019 -0600

    Move computation of RRTMGP cloud optics to suite level, only for LW.

commit f99255d
Author: Dustin Swales <[email protected]>
Date:   Thu May 16 15:26:34 2019 -0600

    Commit for Robert to view.

commit 3beeb50
Author: Dustin Swales <[email protected]>
Date:   Mon May 13 11:55:41 2019 -0600

    Changes for RRTMGP DDTs to be used in CCPP.

commit e0ca272
Author: Dustin Swales <[email protected]>
Date:   Fri May 10 10:58:06 2019 -0600

    Added metadata tables for DDTs. In CCPP/physics, started seperating pieces from suite-level to scheme level.

commit 25b2372
Author: Dustin Swales <[email protected]>
Date:   Thu May 9 15:19:04 2019 -0600

    Added metadata tables to DDT definitions.

commit 232545f
Author: Dustin Swales <[email protected]>
Date:   Wed May 8 14:02:45 2019 -0600

    Added _type to all instances of ty_gas_optics_rrtmgp

commit 81f256d
Author: Dustin Swales <[email protected]>
Date:   Wed May 8 13:48:36 2019 -0600

    Add rte-rrtmgp DDTs to CCPP

commit 0a40aaa
Author: Dustin Swales <[email protected]>
Date:   Tue May 7 15:54:57 2019 -0600

    Moved to using extension/mo_rrtmgp_clr_all_sky.F90 routines to compute fluxes.

commit 6557c76
Author: Dustin Swales <[email protected]>
Date:   Tue May 7 15:12:14 2019 -0600

    Moved RRTMGP code to suite-level.

commit 33e087f
Author: Dustin Swales <[email protected]>
Date:   Thu May 2 15:23:26 2019 -0600

    Cleaned up, added detailed comments, vectorized loops.

commit 8bbbd5b
Author: Dustin Swales <[email protected]>
Date:   Thu May 2 11:34:46 2019 -0600

    Cleaned up RRTGMP_pre a bit. Modified all calculations to use Pa instead of mb.

commit 6c55b93
Author: Dustin Swales <[email protected]>
Date:   Thu May 2 10:04:49 2019 -0600

    Fixed allocation for RRTMGP aerosol/cloudy optical property DDT. Adjusted SW aerosol band ordering in GFS_rrtmgp_pre.F90.

commit d14dba3
Author: Dustin Swales <[email protected]>
Date:   Wed May 1 16:05:13 2019 -0600

    Fixd bug left in from last commit

commit c089f10
Author: Dustin Swales <[email protected]>
Date:   Wed May 1 15:29:19 2019 -0600

    Same stuff as previous commit, but for SW.

commit cf6bd66
Author: Dustin Swales <[email protected]>
Date:   Wed May 1 09:15:21 2019 -0600

    Revised LW flux calculation.

commit e92cd8c
Author: Dustin Swales <[email protected]>
Date:   Tue Apr 30 14:53:24 2019 -0600

    Housekeeping in LW. Remove diffusivity angle adjustment, Added RRTMG draw_samples, Cleaned up aerosol increment, Passing random number to RRTMGP cloud sampling.

commit 3c861b0
Author: Dustin Swales <[email protected]>
Date:   Mon Apr 29 17:29:51 2019 -0600

    LW RRTMGP cloud-optics working. Also, RRTMGP cloud sampling has been implemented (in progress).

commit 67c2e26
Author: Dustin Swales <[email protected]>
Date:   Wed Apr 24 10:53:16 2019 -0600

    Working./gmtb_scm twpice_control_RRTMGP_cloud

commit 5ddf44d
Author: Dustin Swales <[email protected]>
Date:   Thu Apr 18 15:41:45 2019 -0600

    SW all-sky calculation working. Microphysics needs some attention.

commit b4510ef
Author: Dustin Swales <[email protected]>
Date:   Tue Apr 16 12:26:03 2019 -0600

    Added SW clear-sky calculation.

commit 78ab01e
Author: Dustin Swales <[email protected]>
Date:   Tue Apr 16 12:20:17 2019 -0600

    Added SW clear-sky calculation.

commit 9414a90
Author: Dustin Swales <[email protected]>
Date:   Tue Apr 16 12:15:03 2019 -0600

    Added ability to provide cloudy profile to radiation (RRTMG and RRTMGP).

commit 80e70c1
Author: Dustin Swales <[email protected]>
Date:   Fri Mar 22 15:32:19 2019 -0600

    Added diffusivity angle correction to optical-depths.

commit 8240092
Author: Dustin Swales <[email protected]>
Date:   Thu Mar 21 16:57:34 2019 -0600

    Ported RRTMGP development from release repo. LW is working.
climbfuji pushed a commit that referenced this pull request Feb 11, 2021
@joeolson42
Merge pull request #5 from NOAA-GSD/gsd/develop
14e59ca 
updating fork
climbfuji pushed a commit that referenced this pull request Feb 26, 2021
@tanyasmirnova
Merge pull request #5 from climbfuji/bugfixes_tanya_thomp_nc_density
f06e592 
Bugfixes for thomp_nc_density
climbfuji pushed a commit that referenced this pull request Mar 30, 2021
@pjpegion
Merge pull request #5 from NCAR/master
cbe310f 
Update with NCAR fork
climbfuji pushed a commit that referenced this pull request Aug 13, 2021
@XiaSun-Atmos
Merge pull request #5 from climbfuji/constants_update_dom_20210810
ba50531 
Constants update from main 2021/08/10
climbfuji added a commit that referenced this pull request Aug 17, 2021
@climbfuji
Merge pull request #5 from climbfuji/redund_mzhang_update_dom_20210816
e5cdd22 
redund_mzhang update Dom 2021/08/16
climbfuji pushed a commit that referenced this pull request May 20, 2024
@grantfirl
Merge pull request #5 from dustinswales/update_codeowners_grant
dcaa3f4 
Update CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climbfuji climbfuji Awaiting requested review from climbfuji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdtoy @climbfuji @mdtoyNOAA