Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement the <-> subscript alias operator #80

Merged
merged 9 commits into from
Jul 23, 2021
Merged

feat: implement the <-> subscript alias operator #80

merged 9 commits into from
Jul 23, 2021

Conversation

ToddFincannon
Copy link
Collaborator

@ToddFincannon ToddFincannon commented Jul 10, 2021 •
edited by chrispcampbell
Loading

Fixes #78

Implement the <-> subscript alias operator by adding a special case to the subscript factory function with an empty string instead of an index array. Copy the referenced subscript information once all subscripts are read,

@chrispcampbell chrispcampbell changed the title feat: implement the <-> subscript alias operator (#78) feat: implement the <-> subscript alias operator Jul 15, 2021
Base automatically changed from todd/77-get-direct-subscript to develop July 23, 2021 22:58
chrispcampbell
chrispcampbell approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@chrispcampbell chrispcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, looks good.

@chrispcampbell chrispcampbell linked an issue Jul 23, 2021 that may be closed by this pull request
Implement subscript aliases #78
Closed
@chrispcampbell chrispcampbell merged commit a43917f into develop Jul 23, 2021
@chrispcampbell chrispcampbell deleted the todd/78-subscript-alias branch July 23, 2021 23:44
@climateinteractive-bot climateinteractive-bot mentioned this pull request Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispcampbell chrispcampbell chrispcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement subscript aliases
2 participants
@ToddFincannon @chrispcampbell