feat: allow for creating a LookupDef without manually initializing a ModelListing #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnally use bundled listing to resolve lookup variable references
…rSpec and add VarRef type to public API
…ilable and update tests accordingly
…{model}.json` file
…nerated wasm module
…delListing API changes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501
This amends some recent changes that made
ModelListingandVarSpecpart of the public API, so they are now once again treated as implementation details and no longer part of the public API. (Technically they were never part of the public API since we haven't published packages yet that include any of the recent API changes.)See issue for a before/after from a developer's perspective. With these changes, developers don't need to be concerned with what a
ModelListingorVarSpecare used for. The developer can refer to a lookup variable by name or ID, and the implementation will take care of matching it to the correct variable in the generated model. (I will change the way "output indices" are implemented to work similarly, but that will be done in a separate branch later.)