Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: cache last input and last accessed index for faster lookups #43

Merged
merged 1 commit into from
Sep 14, 2020
Merged

perf: cache last input and last accessed index for faster lookups #43

merged 1 commit into from
Sep 14, 2020

Conversation

chrispcampbell
Copy link
Contributor

Fixes #34

@chrispcampbell chrispcampbell merged commit 0933a89 into develop Sep 14, 2020
travisfranck
travisfranck reviewed Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@travisfranck travisfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is any assumption made that LOOKUP tables are always monotonically increasing? The code should work for inverted "U" shaped functions, as well as other relational shapes.

@chrispcampbell chrispcampbell deleted the ccampbell/34-lookup-cache branch December 10, 2020 22:13
@climateinteractive-bot climateinteractive-bot mentioned this pull request Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisfranck travisfranck travisfranck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache last input and accessed index for faster lookups
2 participants
@chrispcampbell @travisfranck