Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add parentheses if needed when reduceConditionals optimization is applied #411

Merged
merged 1 commit into from
Dec 3, 2023
Merged

fix: add parentheses if needed when reduceConditionals optimization is applied #411

merged 1 commit into from
Dec 3, 2023

Conversation

chrispcampbell
Copy link
Contributor

Fixes #410

See issue for more details. I included new tests for reduceExpr and reduceConditionals to check for this case.

@chrispcampbell chrispcampbell merged commit 9269098 into main Dec 3, 2023
6 checks passed
@chrispcampbell chrispcampbell deleted the chris/410-reduce-parens branch December 3, 2023 21:26
@climateinteractive-bot climateinteractive-bot mentioned this pull request Dec 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parentheses omitted when reduceConditionals optimization is applied
1 participant
@chrispcampbell