Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change reduceConditionals to not resolve variable references outside of the condition expression #409

Merged
merged 2 commits into from
Dec 3, 2023
Merged

fix: change reduceConditionals to not resolve variable references outside of the condition expression #409

merged 2 commits into from
Dec 3, 2023

Conversation

chrispcampbell
Copy link
Contributor

Fixes #408

Small fix (with test included) for an issue I found in the new parse package when testing with En-ROADS. More details in the issue.

@chrispcampbell chrispcampbell merged commit 62e1ab1 into main Dec 3, 2023
6 checks passed
@chrispcampbell chrispcampbell deleted the chris/408-reduce-conditionals branch December 3, 2023 06:56
@climateinteractive-bot climateinteractive-bot mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reduceConditionals should not attempt to reduce variable refs outside of the condition expression
1 participant
@chrispcampbell