fix: read blank lines and blank cells in CSV files #309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
I enabled 'csv-parse
flags to not skip empty cells and empty rows in
readCsv`. This fixes the test case in the issue. EPS is building OK with this change.I don't know why these flags were disabled in the first place. Vensim formulas contain absolute cell references that will be incorrect if empty rows and cells are skipped.
The
test:c-int
model tests run OK. I wanted to add the test in the issue todirectconst.mdl
, but the recenth.csv
file with non-numeric cell gives a fatal error in Vensim 9.2.1, so I could not produce the reference.dat
file.